You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/01/16 13:35:49 UTC
[GitHub] zeppelin pull request #1904: [Hot Fix] Fix deadlink in writingzeppelinvisual...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1904
[Hot Fix] Fix deadlink in writingzeppelinvisualization.md
### What is this PR for?
It should point [HeliumVisualizationFactory.java](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationFactory.java) not [HeliumVisualizationPackage.java](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/helium/HeliumVisualizationPackage.java)
### What type of PR is it?
Documentation | HotFix
### What is the Jira issue?
N/A
### How should this be tested?
click `HeliumVisualizationFactory` link in [this section](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinvisualization.html#3-create-and-load-visualization-bundle-on-the-fly) :)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin fix/deadlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1904
----
commit 60ac6c97d5bdc83f6d28e6094769e66e352677ab
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-01-16T13:30:21Z
Fix deadlink in writingzeppelinvisualization.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1904: [Hot Fix] Fix deadlink in writingzeppelinvisualization...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1904
CI failed in Selenium test and it's irrelevant to this change. Will merge into master and branch-0.7 if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1904: [Hot Fix] Fix deadlink in writingzeppelinvisual...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1904: [Hot Fix] Fix deadlink in writingzeppelinvisualization...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1904
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---