You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/12/19 15:59:57 UTC

[GitHub] [nifi] turcsanyip opened a new pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

turcsanyip opened a new pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944
 
 
   https://issues.apache.org/jira/browse/NIFI-6939
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _Enables X functionality; fixes bug NIFI-YYYY._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363287511
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/hook/NotificationSender.java
 ##########
 @@ -290,17 +293,17 @@ void send(final List<HookNotification.HookNotificationMessage> messages, final C
                         // org.json4s.package$MappingException: Can't find ScalaSig for class org.apache.atlas.typesystem.Referenceable
                         flowPathRef.set(ATTR_INPUTS, new ArrayList<>(distinctInputs.values()));
                         flowPathRef.set(ATTR_OUTPUTS, new ArrayList<>(distinctOutputs.values()));
-                        return new HookNotification.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
+                        return new HookNotificationV1.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
                                 ATTR_QUALIFIED_NAME, flowPathQualifiedName, flowPathRef);
                     })
                     .filter(Objects::nonNull)
                     .collect(Collectors.toList());
 
             metrics.uniquePartialNiFiFlowPathUpdates = deduplicatedMessages.size();
-            notifier.accept(deduplicatedMessages);
+            notifier.accept(deduplicatedMessages, null);
 
 Review comment:
   Conisider/Test Kerberized connection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363309469
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -119,3 +125,13 @@ zookeeper.connect=localhost:2181
 
 # Timeout in ms for connecting to zookeeper
 zookeeper.connection.timeout.ms=6000
+
+
+############################# Group Coordinator Settings #############################
+
+# The following configuration specifies the time, in milliseconds, that the GroupCoordinator will delay the initial consumer rebalance.
+# The rebalance will be further delayed by the value of group.initial.rebalance.delay.ms as new members join the group, up to a maximum of max.poll.interval.ms.
 
 Review comment:
   Maybe `further delayed by the same amount` would be easier to understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] mcgilman commented on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

mcgilman commented on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#issuecomment-572196108
 
 
   Thanks for the PR @turcsanyip! Thanks for the review @tpalfy! This has been merged to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363963580
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/hook/NotificationSender.java
 ##########
 @@ -290,17 +293,17 @@ void send(final List<HookNotification.HookNotificationMessage> messages, final C
                         // org.json4s.package$MappingException: Can't find ScalaSig for class org.apache.atlas.typesystem.Referenceable
                         flowPathRef.set(ATTR_INPUTS, new ArrayList<>(distinctInputs.values()));
                         flowPathRef.set(ATTR_OUTPUTS, new ArrayList<>(distinctOutputs.values()));
-                        return new HookNotification.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
+                        return new HookNotificationV1.EntityPartialUpdateRequest(NIFI_USER, TYPE_NIFI_FLOW_PATH,
                                 ATTR_QUALIFIED_NAME, flowPathQualifiedName, flowPathRef);
                     })
                     .filter(Objects::nonNull)
                     .collect(Collectors.toList());
 
             metrics.uniquePartialNiFiFlowPathUpdates = deduplicatedMessages.size();
-            notifier.accept(deduplicatedMessages);
+            notifier.accept(deduplicatedMessages, null);
 
 Review comment:
   Good point. I retested the reporting task with kerberized Atlas servers (version 1.x and 2.0) and it worked fine. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy removed a comment on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy removed a comment on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#issuecomment-572012038
 
 
   LGTM +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] asfgit closed pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

asfgit closed pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363305706
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -21,25 +22,27 @@ broker.id=0
 
 ############################# Socket Server Settings #############################
 
-# The port the socket server listens on
+# The address the socket server listens on. It will get the value returned from 
 
 Review comment:
   This is a bit confusing.
   Is `listeners` a new property while `port` is still a valid alternative? Probably would be better to clarify in the comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363303696
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/java/org/apache/nifi/atlas/reporting/TestReportLineageToAtlas.java
 ##########
 @@ -200,4 +196,86 @@ private void testConnectAndReadTimeout(Map<PropertyDescriptor, String> propertie
         assertEquals(expectedConnectTimeout, actualConnectTimeout);
         assertEquals(expectedReadTimeout, actualReadTimeout);
     }
+
+    @Test
+    public void testNotificationSendingIsSynchronousWhenAtlasConfIsGenerated() throws Exception {
+        String atlasConfDir = createAtlasConfDir();
+
+        Map<PropertyDescriptor, String> properties = initReportingTaskProperties(atlasConfDir);
+
+        ConfigurationContext configurationContext = new MockConfigurationContext(properties, null);
 
 Review comment:
   Could extract this part:
   ```java
       private void testNotificationSendingIsSynchronous(Map<PropertyDescriptor, String> properties) throws InitializationException, IOException, AtlasException {
           ConfigurationContext configurationContext = new MockConfigurationContext(properties, null);
   
           testSubject.initialize(initializationContext);
           testSubject.setup(configurationContext);
   
           Configuration atlasProperties = ApplicationProperties.get();
           boolean isAsync = atlasProperties.getBoolean(AtlasHook.ATLAS_NOTIFICATION_ASYNCHRONOUS, Boolean.TRUE);
           assertFalse(isAsync);
       }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363966173
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -66,14 +69,21 @@ num.partitions=1
 # This value is recommended to be increased for installations with data dirs located in RAID array.
 num.recovery.threads.per.data.dir=1
 
+############################# Internal Topic Settings  #############################
+# The replication factor for the group metadata internal topics "__consumer_offsets" and "__transaction_state"
+# For anything other than development testing, a value greater than 1 is recommended for to ensure availability such as 3.
 
 Review comment:
   See my comment about Kafka `server.properties` above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on issue #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#issuecomment-572012038
 
 
   LGTM +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363309966

##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
##########
@@ -21,25 +22,27 @@ broker.id=0

############################# Socket Server Settings #############################

-# The port the socket server listens on
+# The address the socket server listens on. It will get the value returned from
+# java.net.InetAddress.getCanonicalHostName() if not configured.
+# FORMAT:
+# listeners = listener_name://host_name:port
+# EXAMPLE:
+# listeners = PLAINTEXT://your.host.name:9092
+#listeners=PLAINTEXT://:9092
port=9092

-# Hostname the broker will bind to. If not set, the server will bind to all interfaces
-#host.name=localhost
-
-# Hostname the broker will advertise to producers and consumers. If not set, it uses the
-# value for "host.name" if configured. Otherwise, it will use the value returned from
-# java.net.InetAddress.getCanonicalHostName().
-#advertised.host.name=<hostname routable by clients>
+# Hostname and port the broker will advertise to producers and consumers. If not set,

Review comment:
Minor: In the previous section `address` was used, here `Hostname and port`. Bit confusing (are these different concepts?)
Could use the same (either of the two) at both places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363307519
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -66,14 +69,21 @@ num.partitions=1
 # This value is recommended to be increased for installations with data dirs located in RAID array.
 num.recovery.threads.per.data.dir=1
 
+############################# Internal Topic Settings  #############################
+# The replication factor for the group metadata internal topics "__consumer_offsets" and "__transaction_state"
+# For anything other than development testing, a value greater than 1 is recommended for to ensure availability such as 3.
 
 Review comment:
   `recommended for to` - "to" should be enough

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363304081
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/java/org/apache/nifi/atlas/reporting/TestReportLineageToAtlas.java
 ##########
 @@ -200,4 +196,86 @@ private void testConnectAndReadTimeout(Map<PropertyDescriptor, String> propertie
         assertEquals(expectedConnectTimeout, actualConnectTimeout);
         assertEquals(expectedReadTimeout, actualReadTimeout);
     }
+
+    @Test
+    public void testNotificationSendingIsSynchronousWhenAtlasConfIsGenerated() throws Exception {
+        String atlasConfDir = createAtlasConfDir();
+
+        Map<PropertyDescriptor, String> properties = initReportingTaskProperties(atlasConfDir);
+
+        ConfigurationContext configurationContext = new MockConfigurationContext(properties, null);
+
+        testSubject.initialize(initializationContext);
+        testSubject.setup(configurationContext);
+
+        Configuration atlasProperties = ApplicationProperties.get();
+        boolean isAsync = atlasProperties.getBoolean(AtlasHook.ATLAS_NOTIFICATION_ASYNCHRONOUS, Boolean.TRUE);
+        assertFalse(isAsync);
+    }
+
+    @Test
+    public void testNotificationSendingIsSynchronousWhenAtlasConfIsProvidedAndSynchronousModeHasBeenSet() throws Exception {
+        String atlasConfDir = createAtlasConfDir();
+
+        Properties atlasConf = new Properties();
+        atlasConf.setProperty(AtlasHook.ATLAS_NOTIFICATION_ASYNCHRONOUS, "false");
+        saveAtlasConf(atlasConfDir, atlasConf);
+
+        Map<PropertyDescriptor, String> properties = initReportingTaskProperties(atlasConfDir);
+        properties.put(ATLAS_CONF_CREATE, "false");
+
+        ConfigurationContext configurationContext = new MockConfigurationContext(properties, null);
+
+        testSubject.initialize(initializationContext);
+        testSubject.setup(configurationContext);
+
+        Configuration atlasProperties = ApplicationProperties.get();
+        boolean isAsync = atlasProperties.getBoolean(AtlasHook.ATLAS_NOTIFICATION_ASYNCHRONOUS, Boolean.TRUE);
+        assertFalse(isAsync);
+    }
+
+    @Test(expected = ProcessException.class)
+    public void testNotificationSendingIsSynchronousWhenAtlasConfIsProvidedButSynchronousModeHasNotBeenSet() throws Exception {
 
 Review comment:
   Maybe a name like this would describe the case better: `testThrowExceptionWhenAtlasConfIsProvidedButSynchronousModeHasNotBeenSet`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363966387

##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
##########
@@ -21,25 +22,27 @@ broker.id=0

############################# Socket Server Settings #############################

-# The port to publish to ZooKeeper for clients to use. If this is not set,
-# it will publish the same port that the broker binds to.
-#advertised.port=<port accessible by clients>
+# Maps listener names to security protocols, the default is for them to be the same. See the config documentation for more details
+#listener.security.protocol.map=PLAINTEXT:PLAINTEXT,SSL:SSL,SASL_PLAINTEXT:SASL_PLAINTEXT,SASL_SSL:SASL_SSL

-# The number of threads handling network requests
+# The number of threads that the server uses for receiving requests from the network and sending responses to the network

Review comment:
See my comment about Kafka `server.properties` above.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363965363
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -21,25 +22,27 @@ broker.id=0
 
 ############################# Socket Server Settings #############################
 
-# The port the socket server listens on
+# The address the socket server listens on. It will get the value returned from 
 
 Review comment:
   The `server.properties` file is an original Kafka 2.0 server config file with minimal changes. I would not edit the comments in it.
   I also removed the port=9092 property which was not necessary (and deprecated).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

tpalfy commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363310929

##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
##########
@@ -21,25 +22,27 @@ broker.id=0

############################# Socket Server Settings #############################

-# The number of threads handling network requests
+# The number of threads that the server uses for receiving requests from the network and sending responses to the network

Review comment:
Minor: `The number of threads that the server uses for receiving requests from and sending responses to the network` sounds more natural.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363966250
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
 ##########
 @@ -119,3 +125,13 @@ zookeeper.connect=localhost:2181
 
 # Timeout in ms for connecting to zookeeper
 zookeeper.connection.timeout.ms=6000
+
+
+############################# Group Coordinator Settings #############################
+
+# The following configuration specifies the time, in milliseconds, that the GroupCoordinator will delay the initial consumer rebalance.
+# The rebalance will be further delayed by the value of group.initial.rebalance.delay.ms as new members join the group, up to a maximum of max.poll.interval.ms.
 
 Review comment:
   See my comment about Kafka `server.properties` above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0

Posted by GitBox <gi...@apache.org>.

turcsanyip commented on a change in pull request #3944: NIFI-6939: Upgrade Atlas client dependency to 2.0.0
URL: https://github.com/apache/nifi/pull/3944#discussion_r363966330

##########
File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/test/resources/server.properties
##########
@@ -21,25 +22,27 @@ broker.id=0

############################# Socket Server Settings #############################

Review comment:
See my comment about Kafka `server.properties` above.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services