You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jadami10 (via GitHub)" <gi...@apache.org> on 2023/04/11 00:54:19 UTC
[GitHub] [pinot] jadami10 commented on a diff in pull request #10589: no error metric for queries where all segments are pruned
jadami10 commented on code in PR #10589:
URL: https://github.com/apache/pinot/pull/10589#discussion_r1162198082
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -618,9 +607,15 @@ private BrokerResponseNative handleRequest(long requestId, String query,
}
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
- LOGGER.info("No server found for request {}: {}", requestId, query);
- _brokerMetrics.addMeteredTableValue(rawTableName, BrokerMeter.NO_SERVER_FOUND_EXCEPTIONS, 1);
- return new BrokerResponseNative(exceptions);
+ if (!exceptions.isEmpty()) {
+ LOGGER.info("No server found for request {}: {}", requestId, query);
+ _brokerMetrics.addMeteredTableValue(rawTableName, BrokerMeter.NO_SERVER_FOUND_EXCEPTIONS, 1);
+ return new BrokerResponseNative(exceptions);
+ } else {
+ // When all segments have been pruned, we can just return an empty response.
+ return getEmptyBrokerOnlyResponse(requestId, query, requesterIdentity, requestContext, pinotQuery,
Review Comment:
we have `setNumSegmentsPrunedByBroker`, but we haven't been setting that here. I imagine we could, but I feel like that might be a bigger semantic change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org