You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/02/21 07:09:04 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3658: [ZEPPELIN-4631]. Don't save path in note

zjffdu opened a new pull request #3658: [ZEPPELIN-4631]. Don't save path in note
URL: https://github.com/apache/zeppelin/pull/3658
 
 
   ### What is this PR for?
   This PR just make path in Note.java as `transient`, so it won't be saved in note content. And every time it can be constructed from NotebookRepo when reading it in NoteManager which is the only way to load Note.
   
   
   ### What type of PR is it?
   [ Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4631
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3658: [ZEPPELIN-4631]. Don't save path in note

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3658: [ZEPPELIN-4631]. Don't save path in note
URL: https://github.com/apache/zeppelin/pull/3658#issuecomment-591241793
 
 
   Will merge if no more comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3658: [ZEPPELIN-4631]. Don't save path in note

Posted by GitBox <gi...@apache.org>.
zjffdu commented on issue #3658: [ZEPPELIN-4631]. Don't save path in note
URL: https://github.com/apache/zeppelin/pull/3658#issuecomment-591876175
 
 
   CI pass, will merge if no more comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] asfgit closed pull request #3658: [ZEPPELIN-4631]. Don't save path in note

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3658: [ZEPPELIN-4631]. Don't save path in note
URL: https://github.com/apache/zeppelin/pull/3658
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services