[GitHub] [accumulo] keith-turner commented on pull request #3400: fixes #3399: Access to configuration in context class loader factory

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on PR #3400:
URL: https://github.com/apache/accumulo/pull/3400#issuecomment-1550367786

   >  but the InitParameters doesn't seem to be as accurate as the ...Environment name. 
   
   I think of it as a generic pattern, not something specific to this use.  If an API/SPI method takes 1 parameter and you later want to add another, then it would have to be overloaded.  Overloading is not a great way to evolve methods, especially for plugins.  If each plugin interface method uses a bit of indirection and  only takes one parameter which is an interface that gives access to all of the actual parameters, it makes it much easier to evolve the inputs for the method.  So I see this as a generic pattern that all SPI methods can follow.  If they are all following same pattern, its nice to use the same names.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org