You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2017/05/24 15:09:46 UTC

[GitHub] spark pull request #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark...

GitHub user yanboliang opened a pull request:

    https://github.com/apache/spark/pull/18089

    [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrowth.

    ## What changes were proposed in this pull request?
    Minor fix for PySpark ```FPGrowth```.
    
    ## How was this patch tested?
    Existing UT.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanboliang/spark spark-19281

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18089
    
----
commit 36ab5a59b60a625e3032fa5c8e9ff1d785fe0904
Author: Yanbo Liang <yb...@gmail.com>
Date:   2017-05-24T14:48:46Z

    Minor fix for Pyspark FPGrowth.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/18089


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    **[Test build #77303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77303/testReport)** for PR 18089 at commit [`36ab5a5`](https://github.com/apache/spark/commit/36ab5a59b60a625e3032fa5c8e9ff1d785fe0904).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class HasMinSupport(Params):`
      * `class HasMinConfidence(Params):`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77303/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by zero323 <gi...@git.apache.org>.
Github user zero323 commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    Thanks @yanboliang 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark...

Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18089#discussion_r118280610
  
    --- Diff: python/pyspark/ml/fpm.py ---
    @@ -23,17 +23,17 @@
     __all__ = ["FPGrowth", "FPGrowthModel"]
     
     
    -class HasSupport(Params):
    +class HasMinSupport(Params):
         """
    -    Mixin for param support.
    +    Mixin for param minSupport.
         """
     
         minSupport = Param(
             Params._dummy(),
             "minSupport",
    -        """Minimal support level of the frequent pattern. [0.0, 1.0].
    -        Any pattern that appears more than (minSupport * size-of-the-dataset)
    -        times will be output""",
    +        "Minimal support level of the frequent pattern. [0.0, 1.0]. " +
    +        "Any pattern that appears more than (minSupport * size-of-the-dataset) " +
    +        "times will be output in the frequent itemsets.",
    --- End diff --
    
    Note there will be ```\n``` in the generated Python API docs if using ```"""```.
    
    Before this PR:
    ![image](https://cloud.githubusercontent.com/assets/1962026/26410581/501e99d4-40d6-11e7-86e7-c23ebda9b81e.png)
    
    After this PR:
    ![image](https://cloud.githubusercontent.com/assets/1962026/26410589/583eed1c-40d6-11e7-8779-6cb8232756a6.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    **[Test build #77303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77303/testReport)** for PR 18089 at commit [`36ab5a5`](https://github.com/apache/spark/commit/36ab5a59b60a625e3032fa5c8e9ff1d785fe0904).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #18089: [SPARK-19281][FOLLOWUP][ML] Minor fix for PySpark FPGrow...

Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on the issue:

    https://github.com/apache/spark/pull/18089
  
    Merged into master and branch-2.2. Thanks for reviewing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org