You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:36:17 UTC

[GitHub] [dubbo-go] zouyx commented on a change in pull request #800: enhance client's connectivity

zouyx commented on a change in pull request #800:
URL: https://github.com/apache/dubbo-go/pull/800#discussion_r510020560



##########
File path: remoting/getty/getty_client.go
##########
@@ -204,6 +204,14 @@ func (c *Client) Request(request *remoting.Request, timeout time.Duration, respo
 	return perrors.WithStack(err)
 }
 
+func (c *Client) IsAvailable() bool {
+	client, err := c.pool.get()
+	if client == nil || !client.isAvailable() || err != nil {
+		return false
+	}
+	return true

Review comment:
       ```suggestion
   	return  client != nil && client.isAvailable() && err == nil 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org