You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/09 14:54:01 UTC

[GitHub] [incubator-nuttx-apps] Gary-Hobson commented on a diff in pull request #1403: Makefile: replace INCDIR to INCDIR_PREFIX

Gary-Hobson commented on code in PR #1403:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1403#discussion_r1018043678


##########
interpreters/duktape/Make.defs:
##########
@@ -22,9 +22,9 @@ ifneq ($(CONFIG_INTERPRETERS_DUKTAPE),)
 CONFIGURED_APPS += $(APPDIR)/interpreters/duktape
 
 # It allows `<duktape/duktape.h>` import.
-CFLAGS += ${shell $(INCDIR) "$(CC)" \
-    $(APPDIR)/interpreters/duktape/duktape/src-noline}
-CXXFLAGS += ${shell $(INCDIR) "$(CC)" \
-    $(APPDIR)/interpreters/duktape/duktape/src-noline}
+CFLAGS += ${INCDIR_PREFIX}\

Review Comment:
   all done ~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org