You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/20 09:36:27 UTC

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1550: IGNITE-18585 Sql. Introduce cache for serialized RelNodes representation

korlov42 commented on code in PR #1550:
URL: https://github.com/apache/ignite-3/pull/1550#discussion_r1082287428


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -83,6 +86,13 @@
  * ExecutionServiceImpl. TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
  */
 public class ExecutionServiceImpl<RowT> implements ExecutionService, TopologyEventHandler {
+    private static final int CACHE_SIZE = 1024;
+
+    private static final ConcurrentMap<String, IgniteRel> PHYS_NODES_REPR = Caffeine.newBuilder()

Review Comment:
   honestly speaking, I'm not sure this cache should be static. This can affect the tests in an undesirable way, with no real benefit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org