You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/25 19:16:43 UTC

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4618: Make Kafka offset out of range as an transient exception.

codecov-io edited a comment on issue #4618: Make Kafka offset out of range as an transient exception.
URL: https://github.com/apache/incubator-pinot/pull/4618#issuecomment-546476505
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=h1) Report
   > Merging [#4618](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8d593f384787fc8cdec604629229f8d33ee15c8a?src=pr&el=desc) will **decrease** coverage by `26.22%`.
   > The diff coverage is `37.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4618/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #4618       +/-   ##
   =============================================
   - Coverage     64.33%   38.11%   -26.23%     
   =============================================
     Files          1072     1204      +132     
     Lines         55702    64777     +9075     
     Branches       8131     9422     +1291     
   =============================================
   - Hits          35836    24688    -11148     
   - Misses        17216    37838    +20622     
   + Partials       2650     2251      -399
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../data/aggregator/PercentileEstValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvUGVyY2VudGlsZUVzdFZhbHVlQWdncmVnYXRvci5qYXZh) | `0% <ø> (-100%)` | `0 <0> (ø)` | |
   | [...time/impl/dictionary/OffHeapMutableBytesStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvT2ZmSGVhcE11dGFibGVCeXRlc1N0b3JlLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `58.02% <ø> (-21.92%)` | `0 <0> (ø)` | |
   | [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `83.81% <ø> (-3.47%)` | `0 <0> (ø)` | |
   | [...ion/function/DistinctCountAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50QWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `0% <ø> (-38.54%)` | `0 <0> (ø)` | |
   | [...ion/function/PercentileEstAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlRXN0QWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `0% <ø> (-53.25%)` | `0 <0> (ø)` | |
   | [...gation/function/PercentileAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `0% <ø> (-75%)` | `0 <0> (ø)` | |
   | [.../data/manager/offline/OfflineTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvb2ZmbGluZS9PZmZsaW5lVGFibGVEYXRhTWFuYWdlci5qYXZh) | `85.71% <ø> (-14.29%)` | `0 <0> (ø)` | |
   | [...ator/query/DictionaryBasedAggregationOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWRBZ2dyZWdhdGlvbk9wZXJhdG9yLmphdmE=) | `89.28% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...nction/PercentileTDigestMVAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlVERpZ2VzdE1WQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `0% <ø> (-66.67%)` | `0 <0> (ø)` | |
   | ... and [947 more](https://codecov.io/gh/apache/incubator-pinot/pull/4618/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=footer). Last update [8d593f3...0613984](https://codecov.io/gh/apache/incubator-pinot/pull/4618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org