You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/24 10:25:03 UTC

[GitHub] [arrow-datafusion] alamb commented on issue #6733: Implement serialization for UDWF as window function in plan protobuf #4584

alamb commented on issue #6733:
URL: https://github.com/apache/arrow-datafusion/issues/6733#issuecomment-1605364859

   The basic idea would be to fix this code: https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/to_proto.rs#L593-L597
   
   I think you can generally follow the model of `AggregateUDF`
   
   So I would recommend this order:
   1. Write a round trip test first -- following the model of https://github.com/apache/arrow-datafusion/blob/80d1750fda0f8d1d09d7bbf5b05662b1f6618954/datafusion/proto/src/logical_plan/mod.rs#L2606-L2663
   2. Write the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org