You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2016/02/04 11:33:55 UTC
Tabs in source files are not allowed
Please would all developers (and patch providers) note that tabs are
NOT allowed in source files.
Thanks.
Re: Tabs in source files are not allowed
Posted by Philippe Mouawad <ph...@gmail.com>.
Really nice, Thanks Vladimir and Felix !
On Wednesday, March 2, 2016, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
>
> Am 1. März 2016 22:23:34 MEZ, schrieb Felix Schumacher <
> felix.schumacher@internetallee.de <javascript:;>>:
> >Am 01.03.2016 um 22:04 schrieb Vladimir Sitnikov:
> >>> They are now failing when getting the localhost
> >> I think it is related with JVM buffer overflow:
> >> https://twitter.com/viktorklang/status/704709748885688320
> >The addons: hostname: short-name was in place, already. That was the
> >fix
> >for the first jvm crashes.
> >
> >I think it is a bit like
> >https://github.com/travis-ci/travis-ci/issues/1178
>
> The workaround needed another workaround, which didn't work. So for now, I
> have removed openjdk7 and the workarounds.
>
> The builds passes now with oraclejdk7 and 8.
>
> Regards,
> Felix
> >
> >Felix
> >>
> >> Vladimir
>
>
--
Cordialement.
Philippe Mouawad.
Re: Tabs in source files are not allowed
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 1. März 2016 22:23:34 MEZ, schrieb Felix Schumacher <fe...@internetallee.de>:
>Am 01.03.2016 um 22:04 schrieb Vladimir Sitnikov:
>>> They are now failing when getting the localhost
>> I think it is related with JVM buffer overflow:
>> https://twitter.com/viktorklang/status/704709748885688320
>The addons: hostname: short-name was in place, already. That was the
>fix
>for the first jvm crashes.
>
>I think it is a bit like
>https://github.com/travis-ci/travis-ci/issues/1178
The workaround needed another workaround, which didn't work. So for now, I have removed openjdk7 and the workarounds.
The builds passes now with oraclejdk7 and 8.
Regards,
Felix
>
>Felix
>>
>> Vladimir
Re: Tabs in source files are not allowed
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 01.03.2016 um 22:04 schrieb Vladimir Sitnikov:
>> They are now failing when getting the localhost
> I think it is related with JVM buffer overflow:
> https://twitter.com/viktorklang/status/704709748885688320
The addons: hostname: short-name was in place, already. That was the fix
for the first jvm crashes.
I think it is a bit like https://github.com/travis-ci/travis-ci/issues/1178
Felix
>
> Vladimir
Re: Tabs in source files are not allowed
Posted by Vladimir Sitnikov <si...@gmail.com>.
> They are now failing when getting the localhost
I think it is related with JVM buffer overflow:
https://twitter.com/viktorklang/status/704709748885688320
Vladimir
Re: Tabs in source files are not allowed
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 1. März 2016 17:16:51 MEZ, schrieb Felix Schumacher <fe...@internetallee.de>:
>
>
>Am 29. Februar 2016 23:08:06 MEZ, schrieb Philippe Mouawad
><ph...@gmail.com>:
>>Hi,
>>Thanks Felix.
>>
>>@Vladimir, I see builds are not starting and available PR on github do
>>not
>>seem to be taken into account.
>
>The builds are starting, but a few things need to be addressed in the
>yaml file.
>
>The tests fail since the awt headless property is missing and openjdk
>had a bug with hostnames that are too long.
The tests went a bit farther. They are now failing when getting the localhost. This could have its root in ipv6 only config of travis.
Regards,
Felix
>
>Regards,
>Felix
>>
>>Regards
>>
>>
>>On Mon, Feb 29, 2016 at 7:16 PM, Felix Schumacher <
>>felix.schumacher@internetallee.de> wrote:
>>
>>> Am 29.02.2016 um 11:44 schrieb Vladimir Sitnikov:
>>>
>>>> Thanks, I've started a discussion with Codecov support regarding
>>>> permissions issue.
>>>>
>>>> Looks like Travis job is already trying to build some, so the only
>>>> piece missing is a PR with travis.yml configuration:
>>>> https://travis-ci.org/apache/jmeter/builds
>>>>
>>> I have committed a travis.yml just now. Hope it will run the tests.
>>>
>>> Felix
>>>
>>>>
>>>> Vladimir
>>>>
>>>
Re: Tabs in source files are not allowed
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 29. Februar 2016 23:08:06 MEZ, schrieb Philippe Mouawad <ph...@gmail.com>:
>Hi,
>Thanks Felix.
>
>@Vladimir, I see builds are not starting and available PR on github do
>not
>seem to be taken into account.
The builds are starting, but a few things need to be addressed in the yaml file.
The tests fail since the awt headless property is missing and openjdk had a bug with hostnames that are too long.
Regards,
Felix
>
>Regards
>
>
>On Mon, Feb 29, 2016 at 7:16 PM, Felix Schumacher <
>felix.schumacher@internetallee.de> wrote:
>
>> Am 29.02.2016 um 11:44 schrieb Vladimir Sitnikov:
>>
>>> Thanks, I've started a discussion with Codecov support regarding
>>> permissions issue.
>>>
>>> Looks like Travis job is already trying to build some, so the only
>>> piece missing is a PR with travis.yml configuration:
>>> https://travis-ci.org/apache/jmeter/builds
>>>
>> I have committed a travis.yml just now. Hope it will run the tests.
>>
>> Felix
>>
>>>
>>> Vladimir
>>>
>>
Re: Tabs in source files are not allowed
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Thanks Felix.
@Vladimir, I see builds are not starting and available PR on github do not
seem to be taken into account.
Regards
On Mon, Feb 29, 2016 at 7:16 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
> Am 29.02.2016 um 11:44 schrieb Vladimir Sitnikov:
>
>> Thanks, I've started a discussion with Codecov support regarding
>> permissions issue.
>>
>> Looks like Travis job is already trying to build some, so the only
>> piece missing is a PR with travis.yml configuration:
>> https://travis-ci.org/apache/jmeter/builds
>>
> I have committed a travis.yml just now. Hope it will run the tests.
>
> Felix
>
>>
>> Vladimir
>>
>
--
Cordialement.
Philippe Mouawad.
Re: Tabs in source files are not allowed
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 29.02.2016 um 11:44 schrieb Vladimir Sitnikov:
> Thanks, I've started a discussion with Codecov support regarding
> permissions issue.
>
> Looks like Travis job is already trying to build some, so the only
> piece missing is a PR with travis.yml configuration:
> https://travis-ci.org/apache/jmeter/builds
I have committed a travis.yml just now. Hope it will run the tests.
Felix
>
> Vladimir
Re: Tabs in source files are not allowed
Posted by Vladimir Sitnikov <si...@gmail.com>.
Thanks, I've started a discussion with Codecov support regarding
permissions issue.
Looks like Travis job is already trying to build some, so the only
piece missing is a PR with travis.yml configuration:
https://travis-ci.org/apache/jmeter/builds
Vladimir
Re: Tabs in source files are not allowed
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Created:
https://issues.apache.org/jira/browse/INFRA-11334
Regards
On Thu, Feb 4, 2016 at 10:55 PM, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >Feel free, but I'm not sure where to record this.
>
> I tend to use Travis badge for that.
> See green "build passing" here: [1]
>
> >I wondered about this, but it increases the build time considerably.
>
> Same for me.
> I configure checkstyle job as a separate Travis job. It is not run by
> default, and it is CI-only check.
> See here: [2]. It is clear that unit tests pass and checkstyle fails.
>
> >That's fine, but it's quite a bit of work to do, and it won't help
>
> I can help you with getting Travis configured provided you activate
> Travis - Github integration for the git mirror.
> It would be nice if you could activate "codecov.io - github"
> integration as well.
>
> > and it won't help with SVN commits or non-Git patches.
>
> At least it will cover git patches.
>
> [1]: https://github.com/pgjdbc/pgjdbc#postgresql-jdbc-driver
> [2]: https://travis-ci.org/pgjdbc/pgjdbc/builds/107014742
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: Tabs in source files are not allowed
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Feel free, but I'm not sure where to record this.
I tend to use Travis badge for that.
See green "build passing" here: [1]
>I wondered about this, but it increases the build time considerably.
Same for me.
I configure checkstyle job as a separate Travis job. It is not run by
default, and it is CI-only check.
See here: [2]. It is clear that unit tests pass and checkstyle fails.
>That's fine, but it's quite a bit of work to do, and it won't help
I can help you with getting Travis configured provided you activate
Travis - Github integration for the git mirror.
It would be nice if you could activate "codecov.io - github"
integration as well.
> and it won't help with SVN commits or non-Git patches.
At least it will cover git patches.
[1]: https://github.com/pgjdbc/pgjdbc#postgresql-jdbc-driver
[2]: https://travis-ci.org/pgjdbc/pgjdbc/builds/107014742
Vladimir
Re: Tabs in source files are not allowed
Posted by sebb <se...@gmail.com>.
On 4 February 2016 at 20:42, Philippe Mouawad
<ph...@gmail.com> wrote:
> @sebb, I am responsible if this commit, I was going to fix it this evening
> but you did it before, thanks.
>
> I think:
>
> - we should highlight somewhere
Feel free, but I'm not sure where to record this.
> - or/and add "checkstyle" to "package" ant task so that builld fails
I wondered about this, but it increases the build time considerably.
Perhaps it could be moved to the start of the test phase?
However that itself takes a long time and there is also no guarantee
that committers run the test before committing.
> - or/and follow Vladimir's proposal.
That's fine, but it's quite a bit of work to do, and it won't help
with SVN commits or non-Git patches.
>
> Anyway, my strategy is the following:
>
> - I prefer a contribution that improves the product even if it contains
> tab spaces. Now that you created the check it is easy to find so it is a
> little problem.
If a patch contains a few tabs I'll fix them myself and ask the
provider to remove them from any future patches.
Just as we would with missing AL headers etc.
>
>
>
> On Thu, Feb 4, 2016 at 4:50 PM, Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
>> >However Travis and Jenkins are run on the checked-in source - it's
>> >already too late.
>>
>> Can Jenkins be integrated with Github PRs? It could be possible.
>>
>> Travis can definitely check at the pull request level.
>> It is extremely useful for those who provide Github PRs. Even if the
>> patch has to be converted to bugzilla later.
>>
>> Codecov.io can track code coverage (that is it tracks if pull request
>> adds a sampler that is not covered by the unit tests).
>>
>> Here's an example:
>> https://github.com/pgjdbc/pgjdbc/pull/493#issuecomment-172622681
>>
>> Vladimir
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Tabs in source files are not allowed
Posted by Philippe Mouawad <ph...@gmail.com>.
@sebb, I am responsible if this commit, I was going to fix it this evening
but you did it before, thanks.
I think:
- we should highlight somewhere
- or/and add "checkstyle" to "package" ant task so that builld fails
- or/and follow Vladimir's proposal.
Anyway, my strategy is the following:
- I prefer a contribution that improves the product even if it contains
tab spaces. Now that you created the check it is easy to find so it is a
little problem.
- I think we should be nice with patch providers and developers who work
on their personal time to improve JMeter.
Finally as the french say says:
- "On ne fait pas d'omelette sans casser des oeufs"
Regards
Philippe
On Thu, Feb 4, 2016 at 4:50 PM, Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >However Travis and Jenkins are run on the checked-in source - it's
> >already too late.
>
> Can Jenkins be integrated with Github PRs? It could be possible.
>
> Travis can definitely check at the pull request level.
> It is extremely useful for those who provide Github PRs. Even if the
> patch has to be converted to bugzilla later.
>
> Codecov.io can track code coverage (that is it tracks if pull request
> adds a sampler that is not covered by the unit tests).
>
> Here's an example:
> https://github.com/pgjdbc/pgjdbc/pull/493#issuecomment-172622681
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: Tabs in source files are not allowed
Posted by Vladimir Sitnikov <si...@gmail.com>.
>However Travis and Jenkins are run on the checked-in source - it's
>already too late.
Can Jenkins be integrated with Github PRs? It could be possible.
Travis can definitely check at the pull request level.
It is extremely useful for those who provide Github PRs. Even if the
patch has to be converted to bugzilla later.
Codecov.io can track code coverage (that is it tracks if pull request
adds a sampler that is not covered by the unit tests).
Here's an example:
https://github.com/pgjdbc/pgjdbc/pull/493#issuecomment-172622681
Vladimir
Re: Tabs in source files are not allowed
Posted by sebb <se...@gmail.com>.
On 4 February 2016 at 10:56, Vladimir Sitnikov
<si...@gmail.com> wrote:
> I wonder if https://github.com/apache/jmeter can be integrated with Travis-CI.
> It could be used to check basic things like:
> 1) patch is compilable (against different JDK versions)
> 2) code style is OK. It might be even a single rule like "no tabs"
> 3) unit tests pass
> 4) integration tests (like testing with current jmeter-plugins) pass
>
> I've seen other Apache projects using Travis.
>
> The basic configuration is just a .travis.yml file.
> More advanced could publish artifacts somewhere (e.g. Maven Central)
> for external consumption.
>
> Any interest in setting that up?
We already use Jenkins, which is set up to run checkstyle.
That's how I spotted the issues.
However Travis and Jenkins are run on the checked-in source - it's
already too late.
> Vladimir
Re: Tabs in source files are not allowed
Posted by Vladimir Sitnikov <si...@gmail.com>.
I wonder if https://github.com/apache/jmeter can be integrated with Travis-CI.
It could be used to check basic things like:
1) patch is compilable (against different JDK versions)
2) code style is OK. It might be even a single rule like "no tabs"
3) unit tests pass
4) integration tests (like testing with current jmeter-plugins) pass
I've seen other Apache projects using Travis.
The basic configuration is just a .travis.yml file.
More advanced could publish artifacts somewhere (e.g. Maven Central)
for external consumption.
Any interest in setting that up?
Vladimir