You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/02 02:38:04 UTC

[GitHub] [maven] sungpeo opened a new pull request #529: added an "ignore" option for checksumPolicy in documents

sungpeo opened a new pull request #529:
URL: https://github.com/apache/maven/pull/529


   I didn't create a JIRA issue, this is a trivial change.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] michael-o commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-924193597


   This is how it should look like:
   https://github.com/apache/maven/pull/405/files#diff-507b6c79490c5be04e4f368dded08d6134b27b4880e189c62ec43a1dae4930c1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] gnodet commented on a change in pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #529:
URL: https://github.com/apache/maven/pull/529#discussion_r712767623



##########
File path: maven-settings/src/main/mdo/settings.mdo
##########
@@ -969,7 +969,7 @@
           <version>1.0.0+</version>
           <description>
             What to do when verification of an artifact checksum fails -
-            warn, fail, etc. Valid values are "fail", "warn" (default) or "ignore".
+            warn, fail, etc. Valid values are "fail" (default), "warn" or "ignore".

Review comment:
       Same here imho.
   `What to do when verification of an artifact checksum fails. Valid values are "fail", "warn" (default) or "ignore".`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] sungpeo commented on a change in pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
sungpeo commented on a change in pull request #529:
URL: https://github.com/apache/maven/pull/529#discussion_r713101687



##########
File path: maven-compat/src/main/mdo/profiles.mdo
##########
@@ -308,7 +308,7 @@ under the License.
           <name>checksumPolicy</name>
           <version>1.0.0</version>
           <description>What to do when verification of an artifact checksum fails - warn, fail, etc. Valid values are
-            "fail", "warn" (default) or "ignore"</description>
+            "fail" (default), "warn" or "ignore"</description>

Review comment:
       @gnodet 
   Thanks for the detail correction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] asfgit closed pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #529:
URL: https://github.com/apache/maven/pull/529


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] gnodet commented on a change in pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #529:
URL: https://github.com/apache/maven/pull/529#discussion_r712767193



##########
File path: maven-compat/src/main/mdo/profiles.mdo
##########
@@ -308,7 +308,7 @@ under the License.
           <name>checksumPolicy</name>
           <version>1.0.0</version>
           <description>What to do when verification of an artifact checksum fails - warn, fail, etc. Valid values are
-            "fail", "warn" (default) or "ignore"</description>
+            "fail" (default), "warn" or "ignore"</description>

Review comment:
       Given we list all the values, should we really keep the `- warn, fail, etc.` part after the `What to do when verification of an artifact checksum fails` sentence ?
   Maybe simply:
   `What to do when verification of an artifact checksum fails. Valid values are "fail" (default), "warn" or "ignore".`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] sungpeo commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-924881228


   @michael-o 
   I created a new commit for the default value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] michael-o commented on a change in pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #529:
URL: https://github.com/apache/maven/pull/529#discussion_r712769871



##########
File path: maven-compat/src/main/mdo/profiles.mdo
##########
@@ -308,7 +308,7 @@ under the License.
           <name>checksumPolicy</name>
           <version>1.0.0</version>
           <description>What to do when verification of an artifact checksum fails - warn, fail, etc. Valid values are
-            "fail", "warn" (default) or "ignore"</description>
+            "fail" (default), "warn" or "ignore"</description>

Review comment:
       Correct, avoid duplication.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] sungpeo commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-922473649


   @michael-o 
   Sorry, I made a mistake.
   Default was "fail".
   
   https://github.com/apache/maven/blob/a1ba33069fad1fb9c6e9cd458ad233ff3a74aadd/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java#L40-L46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] sungpeo commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
sungpeo commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-924654485


   @michael-o 
   
   You mean it should be like this(below) ?
   
   `What to do when verification of an artifact checksum fails. Valid values are "fail" (default for Maven 4 and above), "warn" (default for Maven 2 and 3) or "ignore".`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] michael-o commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-924739696


   Correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven] michael-o commented on pull request #529: added an "ignore" option for checksumPolicy in documents

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #529:
URL: https://github.com/apache/maven/pull/529#issuecomment-924168870


   I need to check whether this should be in the model at all. The default value is set in Java code (Maven), not dictated by the model. The model does not change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org