You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/15 03:49:52 UTC

[PR] fix(model): reject unsupported topology node types [rocketmq-dashboard]

btlqql opened a new pull request, #2223:
URL: https://github.com/apache/rocketmq-dashboard/pull/2223

   ## Summary
   
   `ClusterTopology.addNode` now validates the node type before constructing or inserting a node. Null and unsupported values fail atomically, so `nodeMap`, the typed node lists, and aggregate counts cannot diverge after rejected input.
   
   The existing routing for `NAMESRV`, `BROKER`, and `PROXY` nodes is unchanged.
   
   ## Testing
   
   - `mvn -Dtest=ClusterTopologyTest test` (3 tests passed)
   - Maven Checkstyle validation (0 violations)
   
   Fixes #2220
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(model): reject unsupported topology node types [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2223: fix(model): reject unsupported topology node types
URL: https://github.com/apache/rocketmq-dashboard/pull/2223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(model): reject unsupported topology node types [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2223:
URL: https://github.com/apache/rocketmq-dashboard/pull/2223#issuecomment-5338055760

   Thanks for the change. We're closing this one: ClusterTopology currently has no runtime references in the codebase, so hardening its node-type validation brings no observable benefit. We also prefer changes submitted as cohesive, focused PRs per our contribution guideline (#2107). Thanks for understanding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org