You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:58:48 UTC

[GitHub] [helix] huizhilu commented on pull request #1793: Move pause and maintenance handling out of controller

huizhilu commented on pull request #1793:
URL: https://github.com/apache/helix/pull/1793#issuecomment-860017783


   > The change looks good. But there are no tests. Are you planning to add in the next PR?
   
   The existing tests cover the logic of maintenance and cluster status monitoring. Will add unit/integration tests in later PRs.
   
   This PR is ready to be merged. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org