You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Michael Robinson <mi...@astronomer.io.INVALID> on 2023/05/26 16:47:40 UTC
[VOTE] May 2023 PR of the Month
Hello all,
It’s once again time to vote for the PR of the Month.
With the help of the script in dev/stats, I’ve identified the following candidates:
#31240 by @potiuk: "Better typing for Job and JobRunners". <https://github.com/apache/airflow/pull/31240>
#30994 by @potiuk: "Add full automation for min Airflow version for providers". <https://github.com/apache/airflow/pull/30994>
#31308 by @rohan472000: "Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments.". <https://github.com/apache/airflow/pull/31308>
#31277 by @potiuk: "Fix calculation of health check threshold for SchedulerJob". <https://github.com/apache/airflow/pull/31277>
#31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add batch_size param for Vertex AI BatchPredictionJob objects". <https://github.com/apache/airflow/pull/31118>
Please reply to the thread with your selection or offer your own nominee(s).
Voting will close on Tuesday, May 30th at 4 pm ET. The winner will be featured in the next issue of the Airflow Newsletter.
Also, if there’s an article or event that you think should be included in this or a future issue, please drop me a line.
-Michael
Re: [VOTE] May 2023 PR of the Month
Posted by Jarek Potiuk <ja...@potiuk.com>.
I think, to be honest, that PR #27264 (Python 3.11 support) was not as
great PR on its own - it was rather small when it got merged. I mostly
waited and nagged people and rebased it periodically to see where we were.
Don't mistake it with me being overly modest (this one would be strange if
you follow me) but I think my change would have not been possible without
https://github.com/apache/airflow/pull/30067 (Update SDKs for google
provider package) - this one was much more complex, required a close
collaboration between google team, myself, apache.beam team and few others,
solving the conflicting dependencies for google provider - a long standing
issue that was triggered 4 years ago when I was still at Polidea by
backwards-incompatible releases in all google clients.
My vote goes for: https://github.com/apache/airflow/pull/30067
On Sat, May 27, 2023 at 8:45 AM Pankaj Koti
<pa...@astronomer.io.invalid> wrote:
> Yes, agreeing with all so far, I vote for #27264 too.
>
> On Sat, 27 May 2023, 02:58 Daniel Standish,
> <da...@astronomer.io.invalid> wrote:
>
> > you can have any author you like, as long as it is potiuk
> >
> > https://github.com/apache/airflow/pull/27264
> >
> >
> > On Fri, May 26, 2023 at 2:09 PM Hussein Awala <hu...@awala.fr> wrote:
> >
> > > I join Bas and I vote for #27264.
> > >
> > > On Sat 27 May 2023 at 00:03, Bas Harenslak <ba...@astronomer.io.invalid>
> > > wrote:
> > >
> > > > My vote goes to https://github.com/apache/airflow/pull/27264 (Add
> > Python
> > > > 3.11 support).
> > > >
> > > > Bas
> > > >
> > > > > On 26 May 2023, at 18:47, Michael Robinson
> > > > <mi...@astronomer.io.INVALID> wrote:
> > > > >
> > > > > Hello all,
> > > > >
> > > > > It’s once again time to vote for the PR of the Month.
> > > > >
> > > > > With the help of the script in dev/stats, I’ve identified the
> > following
> > > > candidates:
> > > > >
> > > > > #31240 by @potiuk: "Better typing for Job and JobRunners". <
> > > > https://github.com/apache/airflow/pull/31240>
> > > > > #30994 by @potiuk: "Add full automation for min Airflow version for
> > > > providers". <https://github.com/apache/airflow/pull/30994>
> > > > > #31308 by @rohan472000: "Added metavar and choices to --state flag
> in
> > > > airflow dags list-jobs CLI for suggesting valid state arguments.". <
> > > > https://github.com/apache/airflow/pull/31308>
> > > > > #31277 by @potiuk: "Fix calculation of health check threshold for
> > > > SchedulerJob". <https://github.com/apache/airflow/pull/31277>
> > > > > #31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add
> > > > batch_size param for Vertex AI BatchPredictionJob objects". <
> > > > https://github.com/apache/airflow/pull/31118>
> > > > >
> > > > > Please reply to the thread with your selection or offer your own
> > > > nominee(s).
> > > > >
> > > > > Voting will close on Tuesday, May 30th at 4 pm ET. The winner will
> be
> > > > featured in the next issue of the Airflow Newsletter.
> > > > >
> > > > > Also, if there’s an article or event that you think should be
> > included
> > > > in this or a future issue, please drop me a line.
> > > > >
> > > > > -Michael
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org
> > > > For additional commands, e-mail: dev-help@airflow.apache.org
> > > >
> > > >
> > >
> >
>
Re: [VOTE] May 2023 PR of the Month
Posted by Pankaj Koti <pa...@astronomer.io.INVALID>.
Yes, agreeing with all so far, I vote for #27264 too.
On Sat, 27 May 2023, 02:58 Daniel Standish,
<da...@astronomer.io.invalid> wrote:
> you can have any author you like, as long as it is potiuk
>
> https://github.com/apache/airflow/pull/27264
>
>
> On Fri, May 26, 2023 at 2:09 PM Hussein Awala <hu...@awala.fr> wrote:
>
> > I join Bas and I vote for #27264.
> >
> > On Sat 27 May 2023 at 00:03, Bas Harenslak <ba...@astronomer.io.invalid>
> > wrote:
> >
> > > My vote goes to https://github.com/apache/airflow/pull/27264 (Add
> Python
> > > 3.11 support).
> > >
> > > Bas
> > >
> > > > On 26 May 2023, at 18:47, Michael Robinson
> > > <mi...@astronomer.io.INVALID> wrote:
> > > >
> > > > Hello all,
> > > >
> > > > It’s once again time to vote for the PR of the Month.
> > > >
> > > > With the help of the script in dev/stats, I’ve identified the
> following
> > > candidates:
> > > >
> > > > #31240 by @potiuk: "Better typing for Job and JobRunners". <
> > > https://github.com/apache/airflow/pull/31240>
> > > > #30994 by @potiuk: "Add full automation for min Airflow version for
> > > providers". <https://github.com/apache/airflow/pull/30994>
> > > > #31308 by @rohan472000: "Added metavar and choices to --state flag in
> > > airflow dags list-jobs CLI for suggesting valid state arguments.". <
> > > https://github.com/apache/airflow/pull/31308>
> > > > #31277 by @potiuk: "Fix calculation of health check threshold for
> > > SchedulerJob". <https://github.com/apache/airflow/pull/31277>
> > > > #31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add
> > > batch_size param for Vertex AI BatchPredictionJob objects". <
> > > https://github.com/apache/airflow/pull/31118>
> > > >
> > > > Please reply to the thread with your selection or offer your own
> > > nominee(s).
> > > >
> > > > Voting will close on Tuesday, May 30th at 4 pm ET. The winner will be
> > > featured in the next issue of the Airflow Newsletter.
> > > >
> > > > Also, if there’s an article or event that you think should be
> included
> > > in this or a future issue, please drop me a line.
> > > >
> > > > -Michael
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org
> > > For additional commands, e-mail: dev-help@airflow.apache.org
> > >
> > >
> >
>
Re: [VOTE] May 2023 PR of the Month
Posted by Daniel Standish <da...@astronomer.io.INVALID>.
you can have any author you like, as long as it is potiuk
https://github.com/apache/airflow/pull/27264
On Fri, May 26, 2023 at 2:09 PM Hussein Awala <hu...@awala.fr> wrote:
> I join Bas and I vote for #27264.
>
> On Sat 27 May 2023 at 00:03, Bas Harenslak <ba...@astronomer.io.invalid>
> wrote:
>
> > My vote goes to https://github.com/apache/airflow/pull/27264 (Add Python
> > 3.11 support).
> >
> > Bas
> >
> > > On 26 May 2023, at 18:47, Michael Robinson
> > <mi...@astronomer.io.INVALID> wrote:
> > >
> > > Hello all,
> > >
> > > It’s once again time to vote for the PR of the Month.
> > >
> > > With the help of the script in dev/stats, I’ve identified the following
> > candidates:
> > >
> > > #31240 by @potiuk: "Better typing for Job and JobRunners". <
> > https://github.com/apache/airflow/pull/31240>
> > > #30994 by @potiuk: "Add full automation for min Airflow version for
> > providers". <https://github.com/apache/airflow/pull/30994>
> > > #31308 by @rohan472000: "Added metavar and choices to --state flag in
> > airflow dags list-jobs CLI for suggesting valid state arguments.". <
> > https://github.com/apache/airflow/pull/31308>
> > > #31277 by @potiuk: "Fix calculation of health check threshold for
> > SchedulerJob". <https://github.com/apache/airflow/pull/31277>
> > > #31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add
> > batch_size param for Vertex AI BatchPredictionJob objects". <
> > https://github.com/apache/airflow/pull/31118>
> > >
> > > Please reply to the thread with your selection or offer your own
> > nominee(s).
> > >
> > > Voting will close on Tuesday, May 30th at 4 pm ET. The winner will be
> > featured in the next issue of the Airflow Newsletter.
> > >
> > > Also, if there’s an article or event that you think should be included
> > in this or a future issue, please drop me a line.
> > >
> > > -Michael
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org
> > For additional commands, e-mail: dev-help@airflow.apache.org
> >
> >
>
Re: [VOTE] May 2023 PR of the Month
Posted by Hussein Awala <hu...@awala.fr>.
I join Bas and I vote for #27264.
On Sat 27 May 2023 at 00:03, Bas Harenslak <ba...@astronomer.io.invalid>
wrote:
> My vote goes to https://github.com/apache/airflow/pull/27264 (Add Python
> 3.11 support).
>
> Bas
>
> > On 26 May 2023, at 18:47, Michael Robinson
> <mi...@astronomer.io.INVALID> wrote:
> >
> > Hello all,
> >
> > It’s once again time to vote for the PR of the Month.
> >
> > With the help of the script in dev/stats, I’ve identified the following
> candidates:
> >
> > #31240 by @potiuk: "Better typing for Job and JobRunners". <
> https://github.com/apache/airflow/pull/31240>
> > #30994 by @potiuk: "Add full automation for min Airflow version for
> providers". <https://github.com/apache/airflow/pull/30994>
> > #31308 by @rohan472000: "Added metavar and choices to --state flag in
> airflow dags list-jobs CLI for suggesting valid state arguments.". <
> https://github.com/apache/airflow/pull/31308>
> > #31277 by @potiuk: "Fix calculation of health check threshold for
> SchedulerJob". <https://github.com/apache/airflow/pull/31277>
> > #31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add
> batch_size param for Vertex AI BatchPredictionJob objects". <
> https://github.com/apache/airflow/pull/31118>
> >
> > Please reply to the thread with your selection or offer your own
> nominee(s).
> >
> > Voting will close on Tuesday, May 30th at 4 pm ET. The winner will be
> featured in the next issue of the Airflow Newsletter.
> >
> > Also, if there’s an article or event that you think should be included
> in this or a future issue, please drop me a line.
> >
> > -Michael
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org
> For additional commands, e-mail: dev-help@airflow.apache.org
>
>
Re: [VOTE] May 2023 PR of the Month
Posted by Bas Harenslak <ba...@astronomer.io.INVALID>.
My vote goes to https://github.com/apache/airflow/pull/27264 (Add Python 3.11 support).
Bas
> On 26 May 2023, at 18:47, Michael Robinson <mi...@astronomer.io.INVALID> wrote:
>
> Hello all,
>
> It’s once again time to vote for the PR of the Month.
>
> With the help of the script in dev/stats, I’ve identified the following candidates:
>
> #31240 by @potiuk: "Better typing for Job and JobRunners". <https://github.com/apache/airflow/pull/31240>
> #30994 by @potiuk: "Add full automation for min Airflow version for providers". <https://github.com/apache/airflow/pull/30994>
> #31308 by @rohan472000: "Added metavar and choices to --state flag in airflow dags list-jobs CLI for suggesting valid state arguments.". <https://github.com/apache/airflow/pull/31308>
> #31277 by @potiuk: "Fix calculation of health check threshold for SchedulerJob". <https://github.com/apache/airflow/pull/31277>
> #31118 by @VVildVVolf: "`CreateBatchPredictionJobOperator` Add batch_size param for Vertex AI BatchPredictionJob objects". <https://github.com/apache/airflow/pull/31118>
>
> Please reply to the thread with your selection or offer your own nominee(s).
>
> Voting will close on Tuesday, May 30th at 4 pm ET. The winner will be featured in the next issue of the Airflow Newsletter.
>
> Also, if there’s an article or event that you think should be included in this or a future issue, please drop me a line.
>
> -Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org
For additional commands, e-mail: dev-help@airflow.apache.org