[GitHub] jeongyooneo commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex

[GitBox <gi...@apache.org>]

jeongyooneo commented on a change in pull request #115: [NEMO-96] Modularize DataSkewPolicy to use MetricVertex and BarrierVertex
URL: https://github.com/apache/incubator-nemo/pull/115#discussion_r214583979
 
 

 ##########
 File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/task/TaskExecutor.java
 ##########
 @@ -310,21 +320,59 @@ private void doExecute() {
     }
   }
 
+  public void sendDynOptData(final Object element) {
+    Map<Object, Long> dynOptData = (Map<Object, Long>) element;
+    final List<ControlMessage.PartitionSizeEntry> partitionSizeEntries = new ArrayList<>();
+    dynOptData.forEach((key, size) ->
+      partitionSizeEntries.add(
+        ControlMessage.PartitionSizeEntry.newBuilder()
+          .setKey(key == null ? "" : String.valueOf(key))
 
 Review comment:
   There were cases when keys are `null` which lead to exception. I'll add `NULL_KEY` static variable string for it. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services