[GitHub] [incubator-pinot] mayankshriv commented on pull request #6822: Add admin endpoint for Pinot Minon.

[GitBox <gi...@apache.org>]

mayankshriv commented on pull request #6822:
URL: https://github.com/apache/incubator-pinot/pull/6822#issuecomment-823667749


   > Clean and easy from a first look. TLS/SSL will kick in automatically when configured.
   > 
   > Need for auth depends on whether this will be a publicly accessible API. If this is only used internally to the cluster, TLS client auth can handle it for us similar to `pinot-server`. If this is intended to be accessible publicly, I'd suggest to have a short chat about the design.
   
   The purpose here was just to add `/appconfigs` api as in other Pinot components. Given that minion did not even have an admin server running, I had to set it up. There are no api's other than that currently. @Jackie-Jiang Do you think minion will need public api's that would need acls/tls support? Or would those be via the controller?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org