You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/25 09:57:30 UTC
[PR] fix(topic): allow clearing persisted topic remarks [rocketmq-dashboard]
btlqql opened a new pull request, #2572:
URL: https://github.com/apache/rocketmq-dashboard/pull/2572
## What is the purpose of the change
``updateTopic`` only wrote the remark when ``StringUtils.hasText()`` passed, so submitting a blank value behaved exactly like not submitting one and the stored remark could never be removed.
## Brief changelog
- treat a null remark as "not submitted" (keep the stored value) and a submitted blank/whitespace remark as "clear" (store null), trimming the value in between
- echo the persisted remark back on the response so the returned VO reflects the stored state instead of the raw request value
## How was this patch verified
- ``RocketMQAdminClientImplTest`` 37/37 green, including two new cases: blank submission clears the stored remark, omitted remark keeps it
- ``TopicControllerTest`` 14/14 and ``MetadataServiceTest`` 21/21 green on JDK 21
Fixes #2497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): allow clearing persisted topic remarks [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2572: fix(topic): allow clearing persisted topic remarks
URL: https://github.com/apache/rocketmq-dashboard/pull/2572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(topic): allow clearing persisted topic remarks [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2572:
URL: https://github.com/apache/rocketmq-dashboard/pull/2572#issuecomment-5502379580
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org