You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/07 01:40:00 UTC

[jira] [Commented] (IMPALA-10942) Fix memory leak in admission controller

    [ https://issues.apache.org/jira/browse/IMPALA-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425310#comment-17425310 ] 

ASF subversion and git services commented on IMPALA-10942:
----------------------------------------------------------

Commit cee2b42781658f42dc08a41cf88bb2ed2803aaf1 in impala's branch refs/heads/master from Bikramjeet Vig
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cee2b42 ]

IMPALA-10942: Fix memory leak in admission controller

This patch fixes a memory leak in the admission controller where
objects tracking state required for queuing were being retained
despite the query being admitted or rejected immediately.

Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Reviewed-on: http://gerrit.cloudera.org:8080/17893
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Fix memory leak in admission controller
> ---------------------------------------
>
>                 Key: IMPALA-10942
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10942
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.0.0
>            Reporter: Bikramjeet Vig
>            Assignee: Bikramjeet Vig
>            Priority: Critical
>         Attachments: impala4-coordinator-memory-leak-heap-growth-profile.pdf
>
>
> [https://github.com/apache/impala/blob/1a61a8025c87c37921a1bba4c49f754d8bd10bcc/be/src/scheduling/admission-controller.cc#L1196]
> The intent of the aforementioned line in the code was to check and remove the queue_node if the query was not queued. Instead it end up checking whether that flag is a null pointer or not. Since a valid pointer is always sent, this would result in the queue node never being removed resulting in a memory leak   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org