[GitHub] [doris] freesinger commented on a diff in pull request #10322: [feature](JSON datatype)Support JSON datatype

[GitBox <gi...@apache.org>]

freesinger commented on code in PR #10322:
URL: https://github.com/apache/doris/pull/10322#discussion_r918517597


##########
be/src/common/config.h:
##########
@@ -744,6 +744,11 @@ CONF_mInt32(string_type_length_soft_limit_bytes, "1048576");
 CONF_Validator(string_type_length_soft_limit_bytes,
                [](const int config) -> bool { return config > 0 && config <= 2147483643; });
 
+CONF_mInt32(json_type_length_soft_limit_bytes, "1048576");

Review Comment:
   Similar to String type, soft limit for JSON here is used to set max length for binary JSON data, which means the size of each row in ColumnJson should not > 1MB
   Usages:
   - [olap/row_block2.cpp](https://github.com/freesinger/incubator-doris/blob/6e23f46b48a78ea620d891b0184133ec97c3742b/be/src/olap/row_block2.cpp#L292)
   - [olap/types.h](https://github.com/freesinger/incubator-doris/blob/6e23f46b48a78ea620d891b0184133ec97c3742b/be/src/olap/types.h#L1357)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org