You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2009/09/21 15:48:48 UTC

svn commit: r817251 - /myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java

Author: werpu
Date: Mon Sep 21 13:48:47 2009
New Revision: 817251

URL: http://svn.apache.org/viewvc?rev=817251&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2359

fixed the dispatching code so that system-event listeners again will work





Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java?rev=817251&r1=817250&r2=817251&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java Mon Sep 21 13:48:47 2009
@@ -243,7 +243,7 @@
      */
     private static void _publishPostAddToViewEvent(FacesContext context, UIComponent component)
     {
-        context.getApplication().publishEvent(context, PostAddToViewEvent.class, component);
+        context.getApplication().publishEvent(context, PostAddToViewEvent.class, UIComponent.class, component);
         
         if (component.getChildCount() > 0)
         {
@@ -286,7 +286,7 @@
      */
     private static void _publishPreRemoveFromViewEvent(FacesContext context, UIComponent component)
     {
-        context.getApplication().publishEvent(context, PreRemoveFromViewEvent.class, component);
+        context.getApplication().publishEvent(context, PreRemoveFromViewEvent.class, UIComponent.class, component);
         
         if (component.getChildCount() > 0)
         {
@@ -486,7 +486,10 @@
 
             // Call Application.publishEvent(java.lang.Class, java.lang.Object), passing BeforeRenderEvent.class as
             // the first argument and the component instance to be rendered as the second argument.
-            context.getApplication().publishEvent(context, PreRenderComponentEvent.class, this);
+
+            //The main issue we have here is that the listeners are normally just registered to UIComponent, how do we deal with inherited ones?
+            //We have to ask the EG
+            context.getApplication().publishEvent(context,  PreRenderComponentEvent.class, UIComponent.class, this);
 
             Renderer renderer = getRenderer(context);
             if (renderer != null)