[jira] [Commented] (DELTASPIKE-638) re-visit inconsistent handling of @BeforeHandles

["Jason Porter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DELTASPIKE-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031008#comment-14031008 ] 

Jason Porter commented on DELTASPIKE-638:
-----------------------------------------

isHandled should be false if you're doing a throwOriginal, that much looks like it should be a bug. It should also short circuit the rest of the handling. Any time you're going to throw things you're essentially saying, "I can't handle this, and I doubt anything else in the chain can either."

> re-visit inconsistent handling of @BeforeHandles
> ------------------------------------------------
>
>                 Key: DELTASPIKE-638
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-638
>             Project: DeltaSpike
>          Issue Type: Task
>          Components: ExceptionControl-Module
>    Affects Versions: 1.0.0
>            Reporter: Gerhard Petracek
>            Assignee: Jason Porter
>             Fix For: 1.0.1
>
>
> #throwOriginal in a @BeforeHandles method leads to #isHandled true, once there is a @Handles method for the same exception. however, in the end the exception gets thrown.
> reason:
> the 2nd instance of DefaultExceptionEvent (for @Handles methods) in ExceptionHandlerBroadcaster, uses the information from ExceptionToCatchEvent.
> that also leads to the situation that every change done by a @BeforeHandles method isn't visible in a @Handles method.



--
This message was sent by Atlassian JIRA
(v6.2#6252)