You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/02/18 17:01:32 UTC
[GitHub] [openwhisk-wskdeploy] mrutkows opened a new pull request #1118: Fix gogradle plugin to stop using vendor directory
mrutkows opened a new pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781616696
ideally, we switch to a more current gradle plugin such as: https://github.com/innobead/gogradle which works better with go.mod and is more straightforward or eliminate gradle altogether and find a better way to switch OS/ARCH for docker builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] pritidesai merged pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
pritidesai merged pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781602441
My assumption is that the gogradle plugin forces you to use a "/vendor" directory and we really do not want one at all; however, the "go" command assumes that if it sees a "/vendor" directory that it overrides "go.mod". So we need to either:
a) prevent gogradle from installing anything into "/vendor" meaning we need to prevent the `Task :resolveBuildDependencies` and `Task :installDependencies` from installing packages into "/vendor" or
or
b) we set the new flag option on the "go" command i.e., `-mod=mod` to force it to ignore the vendor directory regardless of what gogradle does.
See: https://tip.golang.org/doc/go1.14 for a desc. of this behavior
This blog explains it better and has a demo of switching between go 1.13 and go 1.14: https://www.ardanlabs.com/blog/2020/04/modules-06-vendoring.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-782428229
@pritidesai Thanks Priti!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781602441
My assumption is that the gogradle plugin forces you to use a "/vendor" directory and we really do not want one at all; however, the "go" command assumes that if it sees a "/vendor" directory that it overrides "go.mod". So we need to either prevent gogradle from installing anything into "/vendor" or we set the new flag on the "go" command i.e., `-mod=mod` to force it to ignore the vendor directory.
See: https://tip.golang.org/doc/go1.14 for a desc. of this behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781614463
I should mention that a 3rd option exists, but I discounted it since it basically capitulates to the old gogradle plugin (and also bypasses it for managing deps.) and uses the "go" command to create the vendor directory i.e., `go mod vendor`: https://www.honeybadger.io/blog/golang-go-package-management/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781602441
My assumption is that the gogradle plugin forces you to use a "/vendor" directory and we really do not want one at all; however, the "go" command assumes that if it sees a "/vendor" directory that it overrides "go.mod". So we need to either:
a) prevent gogradle from installing anything into "/vendor" meaning we need to prevent the `Task :resolveBuildDependencies` and `Task :installDependencies` from installing packages into "/vendor" or
or
b) we set the new flag option on the "go" command i.e., `-mod=mod` to force it to ignore the vendor directory regardless of what gogradle does.
See: https://tip.golang.org/doc/go1.14 for a desc. of this behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on pull request #1118: Fix gogradle plugin to stop using vendor directory
Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on pull request #1118:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1118#issuecomment-781602441
My assumption is that the gogradle plugin forces you to use a "/vendor" directory and we really do not want one at all; however, the "go" command assumes that if it sees a "/vendor" directory that it overrides "go.mod". So we need to either:
a) prevent gogradle from installing anything into "/vendor" meaning we need to prevent the `Task :resolveBuildDependencies` and `Task :installDependencies` from installing packages into "/vendor" or
or
b) we set the new flag option on the "go" command i.e., `-mod=mod` to force it to ignore the vendor directory regardless of what gogradle does.
See: https://tip.golang.org/doc/go1.14 for a desc. of this behavior
This blog explains it better and has a demo: https://www.ardanlabs.com/blog/2020/04/modules-06-vendoring.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org