You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Guillaume Nodet <gn...@apache.org> on 2023/06/14 18:58:36 UTC
[VOTE] Release Maven Clean Plugin version 3.3.1
Hi,
Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
we solved 5 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/projects/MCLEAN/issues
Staging repo:
https://repository.apache.org/content/repositories/maven-1961/
https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
Source release checksum(s):
maven-clean-plugin-3.3.1-source-release.zip
sha512:
a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
Staging site:
https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
--
------------------------
Guillaume Nodet
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Tamás Cservenák <ta...@cservenak.net>.
+1
On Wed, Jun 14, 2023 at 8:58 PM Guillaume Nodet <gn...@apache.org> wrote:
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
>
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
>
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
>
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Guillaume Nodet <gn...@apache.org>.
+1
Le mer. 14 juin 2023 à 20:58, Guillaume Nodet <gn...@apache.org> a écrit :
>
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
>
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
>
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
>
>
--
------------------------
Guillaume Nodet
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1
Le mer. 14 juin 2023 à 21:33, Sylwester Lachiewicz <sl...@gmail.com>
a écrit :
> +1
>
> śr., 14 cze 2023 o 20:58 Guillaume Nodet <gn...@apache.org> napisał(a):
>
> > Hi,
> >
> > Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
> >
> > we solved 5 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/projects/MCLEAN/issues
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1961/
> >
> >
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
> >
> > Source release checksum(s):
> > maven-clean-plugin-3.3.1-source-release.zip
> > sha512:
> >
> >
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > --
> > ------------------------
> > Guillaume Nodet
> >
>
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Sylwester Lachiewicz <sl...@gmail.com>.
+1
śr., 14 cze 2023 o 20:58 Guillaume Nodet <gn...@apache.org> napisał(a):
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
>
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
>
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
>
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Slawomir Jaranowski <s....@gmail.com>.
+1
Please fix release notes in jira - it still points to version 3.3.0
śr., 14 cze 2023 o 20:58 Guillaume Nodet <gn...@apache.org> napisał(a):
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
>
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
>
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
>
--
Sławomir Jaranowski
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Guillaume Nodet <gn...@apache.org>.
Le jeu. 15 juin 2023 à 03:24, Elliotte Rusty Harold <el...@ibiblio.org> a
écrit :
> This might not be blocking but there are some dependency issues:
>
> [INFO] --- maven-dependency-plugin:3.4.0:analyze (default-cli) @
> maven-clean-plugin ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] commons-io:commons-io:jar:2.2:test
> [WARNING] org.eclipse.aether:aether-api:jar:1.0.0.v20140518:provided
> [WARNING] Unused declared dependencies found:
> [WARNING] org.codehaus.plexus:plexus-xml:jar:4.0.0:provided
> [WARNING] org.apache.maven:maven-compat:jar:3.2.5:test
> [WARNING] junit:junit:jar:4.13.2:test
>
> The plexus-xml one is particularly interesting. Removing it from the
> pom.xml breaks the build like this:
>
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.04 s <<< FAILURE! - in
> org.apache.maven.plugins.clean.CleanMojoTest
> [ERROR] org.apache.maven.plugins.clean.CleanMojoTest.initializationError
> Time elapsed: 0.013 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/codehaus/plexus/util/xml/XmlStreamReader
>
> This seems to come from the superclass AbstractMojoTestCase. This
> might be an error in the dependency declarations for
> maven-pluign-testing. Or it might be an issue because
> AbstractMojoTestCase expects to find XmlStreamReader in plexus-utils,
> but it's no longer present in plexus-utils 4.0.0. Instead it comes
> from plexus-xml. The more I look at it, the more likely this seems.
>
> So there are two issues here:
>
> 1. maven-dependency-analyzer is reporting a new false negative. In
> general, analysis of dependencies gets much trickier when classes
> belong to different artifacts in different versions.
>
2. The presence of plexus-utils 4.0.0 means that maven-plugin-testing
> no longer correctly declares its dependencies.
>
Good point. I wanted to clean the m-clean-p tests a bit before the
release, but the newest 4.0.0-alpha-1 plugin-testing does not support maven
3.x.
So I took at stab at it and raised
https://github.com/apache/maven-clean-plugin/pull/27 and
https://github.com/apache/maven-plugin-testing/pull/31 which upgrades to
JUnit 5 and fix the dependencies. That could be included for the next
release !
>
> On Wed, Jun 14, 2023 at 6:58 PM Guillaume Nodet <gn...@apache.org> wrote:
> >
> > Hi,
> >
> > Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
> >
> > we solved 5 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/projects/MCLEAN/issues
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1961/
> >
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
> >
> > Source release checksum(s):
> > maven-clean-plugin-3.3.1-source-release.zip
> > sha512:
> >
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > --
> > ------------------------
> > Guillaume Nodet
>
>
>
> --
> Elliotte Rusty Harold
> elharo@ibiblio.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
------------------------
Guillaume Nodet
Re: [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Elliotte Rusty Harold <el...@ibiblio.org>.
This might not be blocking but there are some dependency issues:
[INFO] --- maven-dependency-plugin:3.4.0:analyze (default-cli) @
maven-clean-plugin ---
[WARNING] Used undeclared dependencies found:
[WARNING] commons-io:commons-io:jar:2.2:test
[WARNING] org.eclipse.aether:aether-api:jar:1.0.0.v20140518:provided
[WARNING] Unused declared dependencies found:
[WARNING] org.codehaus.plexus:plexus-xml:jar:4.0.0:provided
[WARNING] org.apache.maven:maven-compat:jar:3.2.5:test
[WARNING] junit:junit:jar:4.13.2:test
The plexus-xml one is particularly interesting. Removing it from the
pom.xml breaks the build like this:
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
elapsed: 0.04 s <<< FAILURE! - in
org.apache.maven.plugins.clean.CleanMojoTest
[ERROR] org.apache.maven.plugins.clean.CleanMojoTest.initializationError
Time elapsed: 0.013 s <<< ERROR!
java.lang.NoClassDefFoundError: org/codehaus/plexus/util/xml/XmlStreamReader
This seems to come from the superclass AbstractMojoTestCase. This
might be an error in the dependency declarations for
maven-pluign-testing. Or it might be an issue because
AbstractMojoTestCase expects to find XmlStreamReader in plexus-utils,
but it's no longer present in plexus-utils 4.0.0. Instead it comes
from plexus-xml. The more I look at it, the more likely this seems.
So there are two issues here:
1. maven-dependency-analyzer is reporting a new false negative. In
general, analysis of dependencies gets much trickier when classes
belong to different artifacts in different versions.
2. The presence of plexus-utils 4.0.0 means that maven-plugin-testing
no longer correctly declares its dependencies.
On Wed, Jun 14, 2023 at 6:58 PM Guillaume Nodet <gn...@apache.org> wrote:
>
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
--
Elliotte Rusty Harold
elharo@ibiblio.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[RESULT] [VOTE] Release Maven Clean Plugin version 3.3.1
Posted by Guillaume Nodet <gn...@apache.org>.
Closing this vote with 5 +1s votes and no other votes.
Guillaume
Le mer. 14 juin 2023 à 20:58, Guillaume Nodet <gn...@apache.org> a écrit :
>
> Hi,
>
> Fwiw, I've burned the 3.3.0 release, hence 3.3.1...
>
> we solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317224&version=12351541
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MCLEAN/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1961/
>
> https://repository.apache.org/content/repositories/maven-1961/org/apache/maven/plugins/maven-clean-plugin/3.3.1/maven-clean-plugin-3.3.1-source-release.zip
>
> Source release checksum(s):
> maven-clean-plugin-3.3.1-source-release.zip
> sha512:
>
> a195d19de931800d243aed24fa4eb86ac0961ed0a487ff88e513bccb183176b4dd401f870ad970f630ed72a86b5826b8b0e0bd50afecbae5ba7fb2d65a0eb9af
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-clean-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> --
> ------------------------
> Guillaume Nodet
>
>
--
------------------------
Guillaume Nodet