You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/01/27 16:21:29 UTC

[1/2] commons-statistics git commit: Use "log1p(x)" instead of "log(1 + x)".

Repository: commons-statistics
Updated Branches:
  refs/heads/master 9cadb96cb -> 12df0cf3d


Use "log1p(x)" instead of "log(1 + x)".


Project: http://git-wip-us.apache.org/repos/asf/commons-statistics/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-statistics/commit/b34e7838
Tree: http://git-wip-us.apache.org/repos/asf/commons-statistics/tree/b34e7838
Diff: http://git-wip-us.apache.org/repos/asf/commons-statistics/diff/b34e7838

Branch: refs/heads/master
Commit: b34e783874339ac1a043f040584d52d54858feaf
Parents: 9cadb96
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
Authored: Sat Jan 27 17:15:53 2018 +0100
Committer: Gilles Sadowski <gi...@harfang.homelinux.org>
Committed: Sat Jan 27 17:15:53 2018 +0100

----------------------------------------------------------------------
 .../org/apache/commons/statistics/distribution/TDistribution.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-statistics/blob/b34e7838/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
----------------------------------------------------------------------
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
index a579e15..e5baad3 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
@@ -77,7 +77,7 @@ public class TDistribution extends AbstractContinuousDistribution {
     @Override
     public double logDensity(double x) {
         final double nPlus1Over2 = dofOver2 + 0.5;
-        return factor - nPlus1Over2 * Math.log(1 + x * x / degreesOfFreedom);
+        return factor - nPlus1Over2 * Math.log1p(x * x / degreesOfFreedom);
     }
 
     /** {@inheritDoc} */


[2/2] commons-statistics git commit: Unnecessary assignments.

Posted by er...@apache.org.
Unnecessary assignments.


Project: http://git-wip-us.apache.org/repos/asf/commons-statistics/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-statistics/commit/12df0cf3
Tree: http://git-wip-us.apache.org/repos/asf/commons-statistics/tree/12df0cf3
Diff: http://git-wip-us.apache.org/repos/asf/commons-statistics/diff/12df0cf3

Branch: refs/heads/master
Commit: 12df0cf3dd6d06f8c385b95f96c1848582d5595c
Parents: b34e783
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
Authored: Sat Jan 27 17:20:31 2018 +0100
Committer: Gilles Sadowski <gi...@harfang.homelinux.org>
Committed: Sat Jan 27 17:20:31 2018 +0100

----------------------------------------------------------------------
 .../commons/statistics/distribution/TDistribution.java | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-statistics/blob/12df0cf3/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
----------------------------------------------------------------------
diff --git a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
index e5baad3..5245ca2 100644
--- a/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
+++ b/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TDistribution.java
@@ -83,22 +83,17 @@ public class TDistribution extends AbstractContinuousDistribution {
     /** {@inheritDoc} */
     @Override
     public double cumulativeProbability(double x) {
-        double ret;
         if (x == 0) {
-            ret = 0.5;
+            return 0.5;
         } else {
             final double t =
                 RegularizedBeta.value(degreesOfFreedom / (degreesOfFreedom + (x * x)),
                                       dofOver2,
                                       0.5);
-            if (x < 0) {
-                ret = 0.5 * t;
-            } else {
-                ret = 1 - 0.5 * t;
-            }
+            return x < 0 ?
+                0.5 * t :
+                1 - 0.5 * t;
         }
-
-        return ret;
     }
 
     /**