You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/02 21:09:08 UTC
[GitHub] [kafka] hachikuji commented on a change in pull request #9677: KAFKA-10799 AlterIsr utilizes ReplicaManager ISR metrics
hachikuji commented on a change in pull request #9677:
URL: https://github.com/apache/kafka/pull/9677#discussion_r534480994
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -45,6 +45,12 @@ import org.apache.kafka.common.{IsolationLevel, TopicPartition}
import scala.collection.{Map, Seq}
import scala.jdk.CollectionConverters._
+trait IsrChangeListener {
Review comment:
Maybe `IsrChangeMetrics`?
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -53,7 +59,7 @@ trait PartitionStateStore {
class ZkPartitionStateStore(topicPartition: TopicPartition,
zkClient: KafkaZkClient,
- replicaManager: ReplicaManager) extends PartitionStateStore {
+ isrChangeListener: IsrChangeListener) extends PartitionStateStore {
Review comment:
Maybe we can move this out of `ZkPartitionStateStore` since we need the dependence on `IsrChangeListener` in `Partition` anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org