Re: [PR] kie-issues#151: Make browser extensions work on other GitHub instances, like github.ibm.com [incubator-kie-tools]

["jomarko (via GitHub)" <gi...@apache.org>]

jomarko commented on code in PR #2126:
URL: https://github.com/apache/incubator-kie-tools/pull/2126#discussion_r1463159471


##########
packages/chrome-extension/src/app/Dependencies.ts:
##########
@@ -62,7 +62,7 @@ export class Dependencies {
 
   public readonly openRepoInExternalEditor = {
     buttonContainerOnRepoHome: () => {
-      return document.querySelector("#repository-details-container .pagehead-actions") as HTMLElement | null;
+      return document.querySelector(".pagehead-actions") as HTMLElement | null;

Review Comment:
   this change to a less specific locator is an effort to increase a chance the extension will work on multiple instances, even if some of them is not the latest github instance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org