You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/08/27 18:13:12 UTC
[GitHub] [trafficcontrol] jrushford opened a new pull request #6147: Updates to the tm-health-client
jrushford opened a new pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147
Updates to the tm-health-client
- fix to ensure marking parents up or down is only done using
the configured reason code.
- fixes an issue where available parents reported by TM are
not marked up when 'enable-active-markdowns' disabled.
- checks for updates to the config file applying new updates.
- reloads the available traffic monitors list with a config
file update.
- reloads the available traffic monitors list if there are
any errors encountered when polling a traffic monitor.
- added a configuration parameter 'tm-update-cycles' to set
a periodic refresh on the available traffic monitors list.
- added a util module and renamed tmutil to tmagent
- refactored unit tests.
## Which Traffic Control components are affected by this PR?
- Traffic Control Cache Config (T3C, formerly ORT)
## What is the best way to verify this PR?
Run the unit tests at trafficcontrol/cache-config/tm-health-client
go test ./...
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147#discussion_r699595653
##########
File path: cache-config/tm-health-client/README.md
##########
@@ -58,6 +58,17 @@ otherwise unavailable, the tm-health-client will utilize the **Traffic Server**
and **Traffic Monitor** has determined that the marked down host is now available,
the client will then utilize the **Traffic Server** tool to mark the host back up.
+Also on each polling cylce the configuration file, **tm-health-client.json** is
Review comment:
SP: "cylce" -> "cycle"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on a change in pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147#discussion_r699654084
##########
File path: cache-config/tm-health-client/README.md
##########
@@ -58,6 +58,17 @@ otherwise unavailable, the tm-health-client will utilize the **Traffic Server**
and **Traffic Monitor** has determined that the marked down host is now available,
the client will then utilize the **Traffic Server** tool to mark the host back up.
+Also on each polling cylce the configuration file, **tm-health-client.json** is
Review comment:
@ocket8888 thanks, I fixed the spelling and squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147#discussion_r699595653
##########
File path: cache-config/tm-health-client/README.md
##########
@@ -58,6 +58,17 @@ otherwise unavailable, the tm-health-client will utilize the **Traffic Server**
and **Traffic Monitor** has determined that the marked down host is now available,
the client will then utilize the **Traffic Server** tool to mark the host back up.
+Also on each polling cylce the configuration file, **tm-health-client.json** is
Review comment:
SP: "cylce" -> "cycle"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on a change in pull request #6147: Updates to the tm-health-client
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #6147:
URL: https://github.com/apache/trafficcontrol/pull/6147#discussion_r699654084
##########
File path: cache-config/tm-health-client/README.md
##########
@@ -58,6 +58,17 @@ otherwise unavailable, the tm-health-client will utilize the **Traffic Server**
and **Traffic Monitor** has determined that the marked down host is now available,
the client will then utilize the **Traffic Server** tool to mark the host back up.
+Also on each polling cylce the configuration file, **tm-health-client.json** is
Review comment:
@ocket8888 thanks, I fixed the spelling and squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org