You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/04/09 13:44:26 UTC
[GitHub] [jena-site] kinow opened a new pull request, #155: Layout and formatting improvements
kinow opened a new pull request, #155:
URL: https://github.com/apache/jena-site/pull/155
I am reading about SHACL and ShEx, and noticed that these pages were not displaying code using Hugo's code highlighter. (before & after screenshots)
Applied the three-backticks to format code to SHACL, ShEx, RDFS, and RDF Connection pages.
I use a large monitor, but organize windows side-by-side, and noticed that the top menu was broken for
Finally, also noticed that the dropdown z-index fix I tried some time ago is not working. Added `!important` to the css statement and it appears to be fixed now.
Happy to squash commits, or drop commits if needed :+1:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow merged pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow merged PR #155:
URL: https://github.com/apache/jena-site/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on a diff in pull request #155: Layout and formatting improvements
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #155:
URL: https://github.com/apache/jena-site/pull/155#discussion_r1161329933
##########
source/documentation/shex/__index.md:
##########
@@ -6,11 +6,8 @@ slug: index
`jena-shex` is an implementation of the
[ShEx (Shape Expressions)](https://shex.io) language.
-<p>
-<i>This implementation is experimental, starting with Jena 4.2.0.
-Please send usage reports and experience to </i>
-<tt>users@jena.apache.org</tt>.
-</p>
+> NOTE: This implementation is experimental, starting with Jena 4.2.0.
+> Please send usage reports and experience to <tt>users@jena.apache.org</tt>.
Review Comment:
This can be removed now it's 4.7.0. ShEx is complete.
##########
source/documentation/rdfs/__index.md:
##########
@@ -137,7 +139,7 @@ curl --data @query.rq \
will return:
-```
+```sparql
Review Comment:
sparql syntax doesn't apply to the test format results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on a diff in pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #155:
URL: https://github.com/apache/jena-site/pull/155#discussion_r1161337311
##########
source/documentation/shex/__index.md:
##########
@@ -6,11 +6,8 @@ slug: index
`jena-shex` is an implementation of the
[ShEx (Shape Expressions)](https://shex.io) language.
-<p>
-<i>This implementation is experimental, starting with Jena 4.2.0.
-Please send usage reports and experience to </i>
-<tt>users@jena.apache.org</tt>.
-</p>
+> NOTE: This implementation is experimental, starting with Jena 4.2.0.
+> Please send usage reports and experience to <tt>users@jena.apache.org</tt>.
Review Comment:
Removed (I left the CSS styles for notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #155: Layout and formatting improvements
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #155:
URL: https://github.com/apache/jena-site/pull/155#issuecomment-1501196740
GPLv3 is probably not possible because it's be a dependency on `jena-site` like a GPL dependency on code would be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #155:
URL: https://github.com/apache/jena-site/pull/155#issuecomment-1501674351
Saw a discussion today about federated queries and had a look at our docs for that. Noticed that some links were not displayed correctly on the ARQ queries page so fixed that
The page about ARQ federated service had no syntax highlight, so I enabled that (used SPARQL for both query & algebra - I tried lisp, but it got all yellow, and the sparql output produced clearer output I think? although some entries are not highlighted...)
One final change to make tables look more consistent (same width, titles with a little padding):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #155:
URL: https://github.com/apache/jena-site/pull/155#issuecomment-1501132952
Oh, almost forgot. I added some `blockquote` style, so that we can use the Markdown `>` to add an admonition (those alert boxes, like NOTE, WARNING, TIP), but without handling different types (i.e. it's a gray box with the text inside for now).
I was going to use this Hugo add-on: https://github.com/martignoni/hugo-notice
But that uses GPLv3, and I wasn't sure if it'd be OK to add that, or if we would have to add a `NOTICE` file. So went with the simplest approach for now. That's to replace some text that was appearing in italic only, in the ShEx page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #155:
URL: https://github.com/apache/jena-site/pull/155#issuecomment-1501208355
>GPLv3 is probably not possible because it's be a dependency on jena-site like a GPL dependency on code would be.
Makes sense, better to write our own little addon (shouldn't be too hard, just need time to remember how to write shortcodes and test).
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on a diff in pull request #155: Layout and formatting improvements
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #155:
URL: https://github.com/apache/jena-site/pull/155#discussion_r1161337609
##########
source/documentation/rdfs/__index.md:
##########
@@ -137,7 +139,7 @@ curl --data @query.rq \
will return:
-```
+```sparql
Review Comment:
I removed the sparql syntax bit :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org