You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Michael Jouravlev (JIRA)" <ji...@apache.org> on 2006/05/04 23:52:19 UTC
[jira] Created: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
chain-config.xml file should be explicitly referenced from web.xml file
-----------------------------------------------------------------------
Key: STR-2858
URL: http://issues.apache.org/struts/browse/STR-2858
Project: Struts Action 1
Type: Improvement
Components: Apps
Versions: 1.3.2
Reporter: Michael Jouravlev
Priority: Trivial
I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Michael Jouravlev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37273 ]
Michael Jouravlev commented on STR-2858:
----------------------------------------
I don't think you can hide chains completely. What about "catalog" and "command" properties of "action" element? Ok, the request processor is different inside, but if regular users do not take advantage of chains building their actions, what is the point?
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Michael Jouravlev (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37273 ]
Michael Jouravlev commented on STR-2858:
----------------------------------------
I don't think you can hide chains completely. What about "catalog" and "command" properties of "action" element? Ok, the request processor is different inside, but if regular users do not take advantage of chains building their actions, what is the point?
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=all ]
James Mitchell resolved STR-2858:
---------------------------------
Resolution: Won't Fix
Ok, I'm closing this as won't fix due to the nature of the ticket summary. If it is decided to change an example app to demonstrate per Martin's suggestion, please do so under a new ticket.
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Martin Cooper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37274 ]
Martin Cooper commented on STR-2858:
------------------------------------
There are two quite separate uses of Chain here, and I believe we should treat them differently.
The first use is the request processor chain itself. As Don mentions, the vast majority of users won't need to know or care about this. In fact, making it too obvious might lead people to start messing with it wtthout understanding it, so IMHO it's better kept out of the way.
The second use is where the application itself is taking advantage of chains. Here, the chain config file should certainly be readily available, since this is the file that users are going to be modifying. For any examples we provide, I agree that this file should be in an obvious location, to help people understand how the app works.
While it's possible to combine both of these uses in a single chain config file, I don't think that would be wise. Separation of concerns and all that.
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Martin Cooper (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37274 ]
Martin Cooper commented on STR-2858:
------------------------------------
There are two quite separate uses of Chain here, and I believe we should treat them differently.
The first use is the request processor chain itself. As Don mentions, the vast majority of users won't need to know or care about this. In fact, making it too obvious might lead people to start messing with it wtthout understanding it, so IMHO it's better kept out of the way.
The second use is where the application itself is taking advantage of chains. Here, the chain config file should certainly be readily available, since this is the file that users are going to be modifying. For any examples we provide, I agree that this file should be in an obvious location, to help people understand how the app works.
While it's possible to combine both of these uses in a single chain config file, I don't think that would be wise. Separation of concerns and all that.
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37272 ]
Don Brown commented on STR-2858:
--------------------------------
I disagree, as I don't think 80% of struts users should know or care about chain. I think Struts should be moving in the direction of more intelligent defaults and conventions, rather than requiring more configuration. In fact, I'd like to see it possible to not require a struts-config.xml at all, instead defaulting to a wildcarded config file covering most basic patterns. That isn't quite possible today, but it could be in the near future once we get 1.3.3 out.
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=all ]
James Mitchell closed STR-2858:
-------------------------------
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2858) chain-config.xml file should be
explicitly referenced from web.xml file
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2858?page=comments#action_37272 ]
Don Brown commented on STR-2858:
--------------------------------
I disagree, as I don't think 80% of struts users should know or care about chain. I think Struts should be moving in the direction of more intelligent defaults and conventions, rather than requiring more configuration. In fact, I'd like to see it possible to not require a struts-config.xml at all, instead defaulting to a wildcarded config file covering most basic patterns. That isn't quite possible today, but it could be in the near future once we get 1.3.3 out.
> chain-config.xml file should be explicitly referenced from web.xml file
> -----------------------------------------------------------------------
>
> Key: STR-2858
> URL: http://issues.apache.org/struts/browse/STR-2858
> Project: Struts Action 1
> Type: Improvement
> Components: Apps
> Versions: 1.3.2
> Reporter: Michael Jouravlev
> Priority: Trivial
>
> I suggest that all Struts 1.3.x samples explicitly use external chain-config.xml file instead of using the one buried in the classpath at org/apache/struts/chain/chain-config.xml. As a consequence, all samples should explicitly refer to chain-config.xml file from web.xml.
> I believe that this will allow to better undertand the inner workings of chain, and to decrease amount of "magic".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira