You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/12/20 13:41:43 UTC

[GitHub] [cassandra-website] ossarga opened a new pull request #85: CASSANDRA-16763: Updates to site-content build tools

ossarga opened a new pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85


   * Cassandra configuration and nodetool pages are no longer committed to git. The changes makes the run.sh -i and -n options redundant and so they have been removed.
     - README. md has been updated to reflect this change
   * Changed site-content Docker file
     - Installed JDK 11 for compiling trunk and cassandra-4.0 branches
     - Made 'build' user a sudo user
   * Changed the documentation generation function in the docker-entrypoint.sh
     - Always makes a copy of the repository if is supplied from the local host calling the container
     - Select the version of JDK to use based on the version of Cassandra being built
   
   CASSANDRA-16763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever commented on pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85#issuecomment-998260699


   one bug i picked up is the nav link are broken with this.
   
   there's now lots of `<a href="//_/"> …` links, which break.
   
   The deployment to staging I had to do… 
   ```
   for f in $(rg -l "href=\"//" content/_) ; do sed -i '' 's/href=\"\/\//href=\"\//g' $f ; done
   ```
   to fix them (to make them `<a href="/_/"> …`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever closed pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever commented on pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85#issuecomment-998168530


   https://cassandra.staged.apache.org/ updated using this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever edited a comment on pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever edited a comment on pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85#issuecomment-998260699


   one bug i picked up is the nav link are broken with this.
   
   there's now lots of `<a href="//_/"> …` links, which break.
   
   The deployment to staging I had to do… 
   ```
   for f in $(rg -l "href=\"//" content/_) ; do sed -i '' 's/href=\"\/\//href=\"\//g' $f ; done
   ```
   to fix them (to make them `<a href="/_/"> …`).
   
   (i also updated [this comment](https://issues.apache.org/jira/browse/CASSANDRA-16761?focusedCommentId=17380763&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17380763) accordingly)
   
   otherwise looks good (and I don't mind fixing the above problem is a separate PR/commit)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever edited a comment on pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever edited a comment on pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85#issuecomment-998260699






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra-website] michaelsembwever commented on pull request #85: CASSANDRA-16763: Updates to site-content build tools

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #85:
URL: https://github.com/apache/cassandra-website/pull/85#issuecomment-998616575


   manually merged with 60dc37bfe004ca9b5e8b31ff794e987a5ced1774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org