You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/08 12:27:36 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request, #15089: [cleanup][txn] Avoid create multiple future and exception handler.
mattisonchao opened a new pull request, #15089:
URL: https://github.com/apache/pulsar/pull/15089
### Motivation
When I try to learn the transaction part features. I found the ``TransactionMetadataStoreService#endTransaction`` method to look complicated. I think I should try to refactor it to reduce the complexity caused by many ``CompletableFuture``.
### Modifications
- Use chain-call to avoid catching exceptions everywhere.
- Try to avoid using multiple CompletableFutures to increase understanding complexity.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #15089: [cleanup][txn] Avoid create multiple future and exception handler.
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #15089:
URL: https://github.com/apache/pulsar/pull/15089#issuecomment-1094063632
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #15089: [cleanup][txn] Avoid create multiple future and exception handler.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #15089:
URL: https://github.com/apache/pulsar/pull/15089#issuecomment-1095887679
@codelipenghui @congbobo184 @liangyepianzhou @Technoboy- PTAL, when you have time :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #15089: [improve][txn] Avoid create multiple future and exception handler.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15089:
URL: https://github.com/apache/pulsar/pull/15089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org