You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/12 02:01:35 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection
chia7712 commented on a change in pull request #8853:
URL: https://github.com/apache/kafka/pull/8853#discussion_r439167614



##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java
##########
@@ -365,51 +366,6 @@ synchronized public DescribeTopicsResult describeTopics(Collection<String> topic
         return new DescribeTopicsResult(topicDescriptions);
     }
 
-    @Override
-    public DescribeConfigsResult describeConfigs(Collection<ConfigResource> resources) {

Review comment:
       this method has default implementation (see https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java#L340) which calls the variety ```describeConfigs(Collection<ConfigResource>, DescribeConfigsOptions)``` so it is ok to remove the new implementation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org