[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23970: [SPARK-27054][BUILD][SQL] Remove the Calcite dependency

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23970: [SPARK-27054][BUILD][SQL] Remove the Calcite dependency
URL: https://github.com/apache/spark/pull/23970#discussion_r262674694
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1467,11 +1466,15 @@
             <groupId>org.apache.avro</groupId>
             <artifactId>avro-mapred</artifactId>
           </exclusion>
-          <!--  this is needed and must be explicitly included later-->
+          <!--  Do not needed calcite if we disable hive.cbo.enable -->
 
 Review comment:
   Maybe, the followings are more accurate with this PR?
   - `Do not needed` -> `Do not need`
   - `if we disable` -> `because we disabled`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org