You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2025/12/04 01:18:49 UTC
[PR] [chore](json) Use const to qualify related functions when possible [doris]
mrhhsg opened a new pull request, #58696:
URL: https://github.com/apache/doris/pull/58696
### What problem does this PR solve?
The `JsonbDocument` and `JsonbValue` should be read-only, so this PR make related functions const.
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609831378
<details>
<summary>TPC-H: <b>Total hot run time: 34902 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 727c4f22294e94b338e8c509331e9df4ba864d0f, data reload: false
------ Round 1 ----------------------------------
q1 17670 5027 4877 4877
q2 2030 315 197 197
q3 10310 1289 742 742
q4 10198 781 313 313
q5 7507 2452 2155 2155
q6 198 171 144 144
q7 965 793 654 654
q8 9348 1406 1097 1097
q9 7031 5258 5378 5258
q10 6852 2191 1771 1771
q11 545 310 286 286
q12 399 379 225 225
q13 17788 3677 3026 3026
q14 225 234 212 212
q15 597 511 517 511
q16 908 856 811 811
q17 676 797 546 546
q18 7848 7147 7197 7147
q19 1249 981 628 628
q20 366 342 227 227
q21 3975 3535 3112 3112
q22 1067 974 963 963
Total cold run time: 107752 ms
Total hot run time: 34902 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4966 4927 4903 4903
q2 314 378 327 327
q3 2119 2669 2287 2287
q4 1295 1783 1328 1328
q5 4219 4523 4612 4523
q6 221 175 129 129
q7 2025 2035 1838 1838
q8 2694 2648 2453 2453
q9 7519 7639 7507 7507
q10 3108 3236 2825 2825
q11 620 547 512 512
q12 661 781 628 628
q13 3605 3890 3293 3293
q14 280 319 285 285
q15 544 506 490 490
q16 909 922 876 876
q17 1218 1504 1438 1438
q18 8094 7828 7821 7821
q19 854 860 898 860
q20 2010 1958 1843 1843
q21 4633 4252 4237 4237
q22 1051 1019 1007 1007
Total cold run time: 52959 ms
Total hot run time: 51410 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609859477
<details>
<summary>TPC-DS: <b>Total hot run time: 182092 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 727c4f22294e94b338e8c509331e9df4ba864d0f, data reload: false
query5 4555 650 501 501
query6 349 244 230 230
query7 4658 520 304 304
query8 311 257 252 252
query9 8737 2623 2657 2623
query10 538 363 306 306
query11 15368 15315 14612 14612
query12 178 125 119 119
query13 1688 595 470 470
query14 6302 3364 3101 3101
query14_1 2976 2962 2970 2962
query15 210 197 187 187
query16 7441 706 537 537
query17 1258 791 650 650
query18 2027 449 348 348
query19 213 217 186 186
query20 138 124 134 124
query21 214 135 119 119
query22 3944 4032 3799 3799
query23 16784 16230 15926 15926
query23_1 16015 15989 16166 15989
query24 6907 1667 1239 1239
query24_1 1221 1229 1247 1229
query25 626 550 495 495
query26 1246 292 171 171
query27 2749 512 353 353
query28 4370 2186 2164 2164
query29 883 670 530 530
query30 324 248 215 215
query31 825 738 657 657
query32 83 78 84 78
query33 638 422 353 353
query34 836 887 579 579
query35 785 827 744 744
query36 890 918 846 846
query37 125 108 92 92
query38 3822 3822 3827 3822
query39 752 766 709 709
query39_1 690 693 874 693
query40 219 132 120 120
query41 67 64 61 61
query42 126 117 114 114
query43 454 439 431 431
query44 1348 774 765 765
query45 196 192 184 184
query46 918 1007 653 653
query47 1655 1738 1615 1615
query48 425 434 346 346
query49 786 495 420 420
query50 711 714 428 428
query51 3927 3891 3910 3891
query52 110 109 106 106
query53 255 281 201 201
query54 303 297 281 281
query55 101 97 100 97
query56 330 325 328 325
query57 1154 1179 1090 1090
query58 285 281 264 264
query59 2356 2374 2341 2341
query60 362 373 343 343
query61 162 155 159 155
query62 789 709 643 643
query63 238 198 200 198
query64 4595 1216 906 906
query65 4006 3977 3972 3972
query66 1148 442 338 338
query67 15132 14937 14787 14787
query68 8434 998 643 643
query69 510 349 321 321
query70 1137 1045 982 982
query71 499 362 323 323
query72 5814 4896 4970 4896
query73 753 625 353 353
query74 8518 8774 8650 8650
query75 3666 3031 2566 2566
query76 3772 1150 760 760
query77 823 408 311 311
query78 9436 9613 8874 8874
query79 2012 892 612 612
query80 667 606 522 522
query81 492 273 246 246
query82 496 143 114 114
query83 275 272 257 257
query84 255 119 99 99
query85 939 505 442 442
query86 375 290 302 290
query87 4013 4108 3966 3966
query88 4074 2298 2274 2274
query89 399 339 304 304
query90 1970 234 216 216
query91 172 174 146 146
query92 86 72 63 63
query93 1699 1053 676 676
query94 734 459 356 356
query95 520 429 419 419
query96 550 601 289 289
query97 2638 2705 2580 2580
query98 258 228 223 223
query99 1405 1408 1295 1295
Total cold run time: 270643 ms
Total hot run time: 182092 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609737953
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609874931
<details>
<summary>ClickBench: <b>Total hot run time: 27.41 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 727c4f22294e94b338e8c509331e9df4ba864d0f, data reload: false
query1 0.06 0.04 0.04
query2 0.10 0.05 0.05
query3 0.25 0.08 0.09
query4 1.61 0.11 0.12
query5 0.27 0.25 0.26
query6 1.22 0.64 0.63
query7 0.03 0.03 0.02
query8 0.06 0.04 0.05
query9 0.57 0.51 0.50
query10 0.55 0.55 0.55
query11 0.15 0.10 0.12
query12 0.14 0.12 0.10
query13 0.63 0.60 0.62
query14 1.00 0.98 0.99
query15 0.82 0.80 0.80
query16 0.40 0.42 0.39
query17 0.99 1.01 0.99
query18 0.23 0.21 0.21
query19 1.95 1.90 1.85
query20 0.02 0.02 0.02
query21 15.44 0.26 0.14
query22 5.04 0.05 0.05
query23 15.98 0.29 0.10
query24 2.81 0.33 0.25
query25 0.09 0.05 0.04
query26 0.15 0.14 0.13
query27 0.08 0.07 0.06
query28 4.34 1.22 1.02
query29 12.59 4.02 3.26
query30 0.28 0.14 0.12
query31 2.81 0.62 0.41
query32 3.23 0.56 0.47
query33 3.01 3.14 3.06
query34 16.77 5.20 4.60
query35 4.55 4.57 4.57
query36 0.69 0.52 0.48
query37 0.12 0.07 0.07
query38 0.07 0.04 0.04
query39 0.05 0.03 0.03
query40 0.17 0.14 0.12
query41 0.08 0.04 0.03
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 99.48 s
Total hot run time: 27.41 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609507261
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609506831
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3610405167
# BE Regression && UT Coverage Report
Increment line coverage `98.53% (67/68)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58696_727c4f22294e94b338e8c509331e9df4ba864d0f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58696_727c4f22294e94b338e8c509331e9df4ba864d0f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.23% (24736/34244) |
| Line Coverage | 58.94% (259714/440665) |
| Region Coverage | 53.89% (216097/400984) |
| Branch Coverage | 55.37% (92286/166674) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3610090172
# BE UT Coverage Report
Increment line coverage `58.11% (43/74)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/727c4f22294e94b338e8c509331e9df4ba864d0f_727c4f22294e94b338e8c509331e9df4ba864d0f/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/727c4f22294e94b338e8c509331e9df4ba864d0f_727c4f22294e94b338e8c509331e9df4ba864d0f/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.35% (18632/34922) |
| Line Coverage | 39.02% (172090/441044) |
| Region Coverage | 33.66% (133338/396164) |
| Branch Coverage | 34.60% (57356/165775) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58696:
URL: https://github.com/apache/doris/pull/58696#issuecomment-3609738047
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](json) Use const to qualify related functions when possible [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #58696:
URL: https://github.com/apache/doris/pull/58696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org