You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/03 11:32:12 UTC
Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Bugs: LENS-174
https://issues.apache.org/jira/browse/LENS-174
Repository: lens
Description
-------
Changes include :
- Fix the query with no measures queried and only expression measures queried.
- Fix the query measures and no expression measures queried
- Incorporated review comments from https://reviews.apache.org/r/34399/
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
Diff: https://reviews.apache.org/r/34991/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
[INFO] Lens .............................................. SUCCESS [2.813s]
[INFO] Lens API .......................................... SUCCESS [20.301s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
[INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
[INFO] Lens DB storage ................................... SUCCESS [20.292s]
[INFO] Lens Query Library ................................ SUCCESS [14.633s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
[INFO] Lens Server ....................................... SUCCESS [5:15.330s]
[INFO] Lens client ....................................... SUCCESS [36.762s]
[INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
[INFO] Lens Examples ..................................... SUCCESS [10.458s]
[INFO] Lens Distribution ................................. SUCCESS [8.112s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
[INFO] Lens Regression ................................... SUCCESS [15.137s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:01.492s
[INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
[INFO] Final Memory: 160M/959M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/#review87139
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 4, 2015, 2:59 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34991/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 2:59 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-174
> https://issues.apache.org/jira/browse/LENS-174
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Fix the query with no measures queried and only expression measures queried.
> - Fix the query measures and no expression measures queried
> - Incorporated review comments from https://reviews.apache.org/r/34399/
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
>
> Diff: https://reviews.apache.org/r/34991/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
> [INFO] Lens .............................................. SUCCESS [2.813s]
> [INFO] Lens API .......................................... SUCCESS [20.301s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
> [INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
> [INFO] Lens DB storage ................................... SUCCESS [20.292s]
> [INFO] Lens Query Library ................................ SUCCESS [14.633s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
> [INFO] Lens Server ....................................... SUCCESS [5:15.330s]
> [INFO] Lens client ....................................... SUCCESS [36.762s]
> [INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
> [INFO] Lens Examples ..................................... SUCCESS [10.458s]
> [INFO] Lens Distribution ................................. SUCCESS [8.112s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
> [INFO] Lens Regression ................................... SUCCESS [15.137s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:01.492s
> [INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
> [INFO] Final Memory: 160M/959M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/
-----------------------------------------------------------
(Updated June 4, 2015, 9:29 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Review comments fixed.
Bugs: LENS-174
https://issues.apache.org/jira/browse/LENS-174
Repository: lens
Description
-------
Changes include :
- Fix the query with no measures queried and only expression measures queried.
- Fix the query measures and no expression measures queried
- Incorporated review comments from https://reviews.apache.org/r/34399/
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
Diff: https://reviews.apache.org/r/34991/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
[INFO] Lens .............................................. SUCCESS [2.813s]
[INFO] Lens API .......................................... SUCCESS [20.301s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
[INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
[INFO] Lens DB storage ................................... SUCCESS [20.292s]
[INFO] Lens Query Library ................................ SUCCESS [14.633s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
[INFO] Lens Server ....................................... SUCCESS [5:15.330s]
[INFO] Lens client ....................................... SUCCESS [36.762s]
[INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
[INFO] Lens Examples ..................................... SUCCESS [10.458s]
[INFO] Lens Distribution ................................. SUCCESS [8.112s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
[INFO] Lens Regression ................................... SUCCESS [15.137s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:01.492s
[INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
[INFO] Final Memory: 160M/959M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/#review86557
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
<https://reviews.apache.org/r/34991/#comment138618>
Let's not rely on lombok and write a getter with correct name.
- Rajat Khandelwal
On June 3, 2015, 3:02 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34991/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 3:02 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-174
> https://issues.apache.org/jira/browse/LENS-174
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Fix the query with no measures queried and only expression measures queried.
> - Fix the query measures and no expression measures queried
> - Incorporated review comments from https://reviews.apache.org/r/34399/
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
>
> Diff: https://reviews.apache.org/r/34991/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
> [INFO] Lens .............................................. SUCCESS [2.813s]
> [INFO] Lens API .......................................... SUCCESS [20.301s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
> [INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
> [INFO] Lens DB storage ................................... SUCCESS [20.292s]
> [INFO] Lens Query Library ................................ SUCCESS [14.633s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
> [INFO] Lens Server ....................................... SUCCESS [5:15.330s]
> [INFO] Lens client ....................................... SUCCESS [36.762s]
> [INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
> [INFO] Lens Examples ..................................... SUCCESS [10.458s]
> [INFO] Lens Distribution ................................. SUCCESS [8.112s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
> [INFO] Lens Regression ................................... SUCCESS [15.137s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:01.492s
> [INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
> [INFO] Final Memory: 160M/959M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 4, 2015, 6:04 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java, line 288
> > <https://reviews.apache.org/r/34991/diff/1/?file=977316#file977316line288>
> >
> > Is this special handling needed? I think the `findCoveringSets` will take care of this.
No, was seeing issues when only dimattributes are queried - with no measures or expressions. So, this handling is required.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/#review86554
-----------------------------------------------------------
On June 3, 2015, 9:32 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34991/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 9:32 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-174
> https://issues.apache.org/jira/browse/LENS-174
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Fix the query with no measures queried and only expression measures queried.
> - Fix the query measures and no expression measures queried
> - Incorporated review comments from https://reviews.apache.org/r/34399/
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
>
> Diff: https://reviews.apache.org/r/34991/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
> [INFO] Lens .............................................. SUCCESS [2.813s]
> [INFO] Lens API .......................................... SUCCESS [20.301s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
> [INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
> [INFO] Lens DB storage ................................... SUCCESS [20.292s]
> [INFO] Lens Query Library ................................ SUCCESS [14.633s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
> [INFO] Lens Server ....................................... SUCCESS [5:15.330s]
> [INFO] Lens client ....................................... SUCCESS [36.762s]
> [INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
> [INFO] Lens Examples ..................................... SUCCESS [10.458s]
> [INFO] Lens Distribution ................................. SUCCESS [8.112s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
> [INFO] Lens Regression ................................... SUCCESS [15.137s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:01.492s
> [INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
> [INFO] Final Memory: 160M/959M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 34991: LENS-174 : Cube rewriter changes to support
multiple expressions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34991/#review86554
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
<https://reviews.apache.org/r/34991/#comment138615>
Is this special handling needed? I think the `findCoveringSets` will take care of this.
- Rajat Khandelwal
On June 3, 2015, 3:02 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34991/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 3:02 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-174
> https://issues.apache.org/jira/browse/LENS-174
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Fix the query with no measures queried and only expression measures queried.
> - Fix the query measures and no expression measures queried
> - Incorporated review comments from https://reviews.apache.org/r/34399/
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 2ad2b7c
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 4d3443c
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java d56fb80
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 0409af3
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java f2a7039
>
> Diff: https://reviews.apache.org/r/34991/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.877s]
> [INFO] Lens .............................................. SUCCESS [2.813s]
> [INFO] Lens API .......................................... SUCCESS [20.301s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.134s]
> [INFO] Lens Cube ......................................... SUCCESS [3:57.179s]
> [INFO] Lens DB storage ................................... SUCCESS [20.292s]
> [INFO] Lens Query Library ................................ SUCCESS [14.633s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:57.830s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.140s]
> [INFO] Lens Server ....................................... SUCCESS [5:15.330s]
> [INFO] Lens client ....................................... SUCCESS [36.762s]
> [INFO] Lens CLI .......................................... SUCCESS [3:21.390s]
> [INFO] Lens Examples ..................................... SUCCESS [10.458s]
> [INFO] Lens Distribution ................................. SUCCESS [8.112s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.369s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.760s]
> [INFO] Lens Regression ................................... SUCCESS [15.137s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:01.492s
> [INFO] Finished at: Wed Jun 03 09:28:53 UTC 2015
> [INFO] Final Memory: 160M/959M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>