You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/09/03 14:34:39 UTC

[GitHub] [activemq-artemis] ViliusS opened a new pull request, #4206: NO-JIRA Change docker base image version from JDK to JRE

ViliusS opened a new pull request, #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206

   JRE is enough to run most Java software, including ActiveMQ Artemis.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] ViliusS commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
ViliusS commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1248933731

   The difference is 250MB vs 450MB.
   
   I would agree that running Artemis in development JDK tools could be needed, but I don't agree that including these tools in production (even if needed sometimes) is good idea. Generally production images should be a slim as possible to reduce attack surface, size for fast development, etc. etc.
   
   Maybe it is better to have two Dockerfiles then, one for development and one for production, clearly marked? If you think that would be better, I can adjust PR. Also it's probably wise to forgo Debian image as it is built against deprecated openjdk image which is not updated anymore https://github.com/docker-library/openjdk/issues/505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] brusdev commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
brusdev commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1250129357

   Save 200MB would be great, +1 on having two Dockerfiles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] ViliusS commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
ViliusS commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1250367194

   OK, I have added JRE option as a separate Dockerfile.
   
   I have also removed Debian image which used now deprecated OpenJDK build, and converted CentOS image to also use Eclipse-Temurin. Previous jboss/base-jdk image was not updated for the past 2 years.
   
   Hopefully this will satisfy everyone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
jbertram commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1248804362

   @ViliusS, can you quantify the difference this will make in the size of the image?
   
   For what it's worth, lots of folks use JDK tools during development **and** production (e.g. when issues arise). It can be really convenient to have them around when things go badly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] brusdev commented on pull request #4206: NO-JIRA Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
brusdev commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1239796593

   I guess we would lose JDK diagnostic tools. What are the benefits to change base image from JDK to JRE?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] ViliusS commented on pull request #4206: NO-JIRA Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
ViliusS commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1239876267

   Smaller uncompressed image size on disk.
   
   I guess the decision depends on how these docker images are seen. Are they for development or as a base images for production?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] jbertram commented on pull request #4206: ARTEMIS-3983 Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
jbertram commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1249507653

   @ViliusS I think having the option to choose JRE or JDK would be great since one size doesn't fit all in this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #4206: NO-JIRA Change docker base image version from JDK to JRE

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on PR #4206:
URL: https://github.com/apache/activemq-artemis/pull/4206#issuecomment-1239944056

   Ill let others discuss merits of jdk vs jre ... but this would require a jira, this isnt a small typo or doc fix. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [activemq-artemis] asfgit closed pull request #4206: ARTEMIS-3983 Update all docker base images to use Eclipse-Temurin

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4206: ARTEMIS-3983 Update all docker base images to use Eclipse-Temurin
URL: https://github.com/apache/activemq-artemis/pull/4206


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org