You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@burr.apache.org by "CanReader (via GitHub)" <gi...@apache.org> on 2026/10/04 18:03:04 UTC

[PR] Add get_prior_action to Application [burr]

CanReader opened a new pull request, #943:
URL: https://github.com/apache/burr/pull/943

   ## Summary
   
   - Add `Application.get_prior_action()`, the counterpart of `get_next_action()`
   - Returns the action that ran in the last step, or `None` if nothing has run yet
   - Uses the `__PRIOR_STEP` value that is already kept in state
   
   Closes #502
   
   ## Testing
   
   - Added `test_app_get_prior_action`, it checks before any step, after each step and after `reset_to_entrypoint()`
   - `tests/core/test_application.py` passes locally, pre-commit hooks pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add get_prior_action to Application [burr]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #943:
URL: https://github.com/apache/burr/pull/943#issuecomment-6412824988

   This PR has been inactive for 19 days after receiving review feedback.
   Converting to draft.
   
   Please mark it as ready for review when you have addressed the comments.
   If no activity occurs within 90 days, it will be closed automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add get_prior_action to Application [burr]

Posted by "sangkyoonnam (via GitHub)" <gi...@apache.org>.
sangkyoonnam commented on PR #943:
URL: https://github.com/apache/burr/pull/943#issuecomment-6022224948

   Thanks for the update! The docstring clarification and added test address my comments. I reran `tests/core/test_application.py` on `f0e1df9`: all 141 tests pass. No further concerns from me.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add get_prior_action to Application [burr]

Posted by "CanReader (via GitHub)" <gi...@apache.org>.
CanReader commented on PR #943:
URL: https://github.com/apache/burr/pull/943#issuecomment-6021891756

   Thanks @sangkyoonnam  for checking. I Agree on keeping the ValueError, if the state points to an action the graph doesn't have anymore I'd rather it fail loudly than return None like nothing ran.
   
   Just pushed a new update:
   - Docstring now says it raises a ValueError when the prior action isn't in the graph (like after restoring a checkpoint saved with an older graph).
   - Also added the timing part from #502: in `pre_run_step` you get the action before the current one, in `post_run_step` the one that just finished, and for streaming it only moves once the stream is fully consumed.
   - Added `test_app_get_prior_action_not_in_graph` for the raise case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org