[GitHub] [helix] jiajunwang commented on a change in pull request #834: Complete the Routing Table Provider for CustomizedView

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #834: Complete the Routing Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r388644320
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/PropertyPathBuilder.java
 ##########
 @@ -72,6 +74,7 @@
     typeToClassMapping.put(IDEALSTATES, IdealState.class);
     typeToClassMapping.put(CONFIGS, InstanceConfig.class);
     typeToClassMapping.put(EXTERNALVIEW, ExternalView.class);
+    typeToClassMapping.put(CUSTOMIZEDVIEW, CustomizedView.class);
 
 Review comment:
   Is it overlapped with Meng's PR?
   https://github.com/apache/helix/pull/851/files
   
   Can we change this part as a pre-requisite change so both of you are on the same page.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org