You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/07 16:26:07 UTC
[GitHub] [incubator-tuweni] melowe opened a new pull request #207: Add Auto-Module-Name attribute to manifest.mf
melowe opened a new pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207
## PR description
Add Auto-Module-Name attribute to manifest.mf
## Fixed Issue(s)
Fixes #206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (038bb62) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **decrease** coverage by `4.57%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 65.52% 60.95% -4.58%
+ Complexity 4300 3988 -312
============================================
Files 401 376 -25
Lines 21435 21054 -381
Branches 2812 2805 -7
============================================
- Hits 14046 12833 -1213
- Misses 5823 6779 +956
+ Partials 1566 1442 -124
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.95% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-6.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...038bb62](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (abc6439) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
=========================================
Coverage 65.52% 65.53%
Complexity 4300 4300
=========================================
Files 401 401
Lines 21435 21435
Branches 2812 2812
=========================================
+ Hits 14046 14047 +1
- Misses 5823 5825 +2
+ Partials 1566 1563 -3
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.04% <ø> (ø)` | `0.00 <ø> (ø)` | |
| unit | `60.91% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `67.85% <0.00%> (-1.79%)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `49.40% <0.00%> (-0.48%)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/evm/impl/berlin/OpCodes.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZXZtL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9ldm0vaW1wbC9iZXJsaW4vT3BDb2Rlcy5rdA==) | `80.85% <0.00%> (+0.39%)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.42% <0.00%> (+0.79%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...abc6439](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-818537861
> Is there a way to test this?
Well I've built and published to my local repo and I've been building besu branch (that defines module-info.java) against it. I get a `jar -d -f` would be a way of testing it. I'd assume in Automatic-Module-Name will always we a temporary measure and having module-info's define in the modules would be a longer term goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (038bb62) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **decrease** coverage by `4.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 65.52% 60.93% -4.59%
+ Complexity 4300 3988 -312
============================================
Files 401 376 -25
Lines 21435 21054 -381
Branches 2812 2805 -7
============================================
- Hits 14046 12830 -1216
- Misses 5823 6779 +956
+ Partials 1566 1445 -121
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.93% <ø> (+0.02%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-6.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [71 more](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...038bb62](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme commented on a change in pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#discussion_r611946958
##########
File path: build.gradle
##########
@@ -355,14 +355,19 @@ allprojects {
// Packaging and deployment
tasks.withType(Jar) {
+ def moduleName = rootProject.name
if (rootProject == project) {
archiveBaseName = project.name
} else {
archiveBaseName = rootProject.name + '-' + project.name
+ moduleName += ".${project.name}"
}
+
manifest {
attributes('Implementation-Title': archiveBaseName,
- 'Implementation-Version': project.version)
+ 'Implementation-Version': project.version,
+ 'Automatic-Module-Name': moduleName.replaceAll("-","\\.")
Review comment:
Do we have modules that have a `-` in their names? like devp2p-eth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-820027207
Sure thing. We can in this case test it by importing a built jar in the classpath of a java process and see if the modules work. Which dependency shall we test with? Bytes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-818231063
Is there a way to test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-903216089
@melowe closing this PR for inactivity. Please let me know if this is still an issue, happy to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme closed pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme closed pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (038bb62) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **decrease** coverage by `4.57%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 038bb62 differs from pull request most recent head abc6439. Consider uploading reports for the commit abc6439 to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 65.52% 60.95% -4.58%
+ Complexity 4300 3988 -312
============================================
Files 401 376 -25
Lines 21435 21054 -381
Branches 2812 2805 -7
============================================
- Hits 14046 12833 -1213
- Misses 5823 6779 +956
+ Partials 1566 1442 -124
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.95% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-6.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...abc6439](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (461c56f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 461c56f differs from pull request most recent head 038bb62. Consider uploading reports for the commit 038bb62 to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
+ Coverage 65.52% 65.56% +0.03%
Complexity 4300 4300
============================================
Files 401 401
Lines 21435 21435
Branches 2812 2812
============================================
+ Hits 14046 14053 +7
+ Misses 5823 5816 -7
Partials 1566 1566
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.97% <ø> (-0.07%)` | `0.00 <ø> (ø)` | |
| unit | `60.94% <ø> (+0.02%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `80.85% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/evm/impl/berlin/OpCodes.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZXZtL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9ldm0vaW1wbC9iZXJsaW4vT3BDb2Rlcy5rdA==) | `80.66% <0.00%> (+0.19%)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.42% <0.00%> (+0.79%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
| [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `82.90% <0.00%> (+3.41%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...038bb62](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-824062821
> Sure thing. We can in this case test it by importing a built jar in the classpath of a java process and see if the modules work. Which dependency shall we test with? Bytes?
I've been working through the whole thing so I'll end up testing all of them. I'm having to get to grips with some of the more creative Gradle usage at the moment and deal with more dependencies. I'll see how I get on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (461c56f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 461c56f differs from pull request most recent head 038bb62. Consider uploading reports for the commit 038bb62 to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
+ Coverage 65.52% 65.56% +0.03%
Complexity 4300 4300
============================================
Files 401 401
Lines 21435 21435
Branches 2812 2812
============================================
+ Hits 14046 14053 +7
+ Misses 5823 5816 -7
Partials 1566 1566
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.97% <ø> (-0.07%)` | `0.00 <ø> (ø)` | |
| unit | `60.94% <ø> (+0.02%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `80.85% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/evm/impl/berlin/OpCodes.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZXZtL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9ldm0vaW1wbC9iZXJsaW4vT3BDb2Rlcy5rdA==) | `80.66% <0.00%> (+0.19%)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.42% <0.00%> (+0.79%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
| [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `82.90% <0.00%> (+3.41%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...038bb62](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe closed pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe closed pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-828140708
Let me know if we can help, and thanks for looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe closed pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe closed pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-818537861
> Is there a way to test this?
Well I've built and published to my local repo and I've been building besu branch (that defines module-info.java) against it. I get a `jar -d -f` would be a way of testing it. I'd assume in Automatic-Module-Name will always we a temporary measure and having module-info's define in the modules would be a longer term goal.
Beware that the jar tool permits hyphens in the module names for some reason, but these are illegal and result in compiler errors when defining in module-info.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (abc6439) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **decrease** coverage by `4.61%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
- Coverage 65.52% 60.91% -4.62%
+ Complexity 4300 3988 -312
============================================
Files 401 376 -25
Lines 21435 21054 -381
Branches 2812 2805 -7
============================================
- Hits 14046 12825 -1221
- Misses 5823 6787 +964
+ Partials 1566 1442 -124
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.91% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...org/apache/tuweni/devp2p/proxy/ProxySubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwLXByb3h5L3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvcHJveHkvUHJveHlTdWJwcm90b2NvbC5rdA==) | `14.28% <0.00%> (-85.72%)` | `1.00% <0.00%> (-6.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [72 more](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...abc6439](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815071295
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=h1) Report
> Merging [#207](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=desc) (abc6439) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc) (4e68c5a) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #207 +/- ##
============================================
+ Coverage 65.52% 65.57% +0.04%
Complexity 4300 4300
============================================
Files 401 401
Lines 21435 21435
Branches 2812 2812
============================================
+ Hits 14046 14055 +9
+ Misses 5823 5815 -8
+ Partials 1566 1565 -1
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.04% <ø> (ø)` | `0.00 <ø> (ø)` | |
| unit | `60.95% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/evm/impl/berlin/OpCodes.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZXZtL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9ldm0vaW1wbC9iZXJsaW4vT3BDb2Rlcy5rdA==) | `80.85% <0.00%> (+0.39%)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.42% <0.00%> (+0.79%)` | `0.00% <0.00%> (ø%)` | |
| [.../kotlin/org/apache/tuweni/jsonrpc/JSONRPCClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-anNvbnJwYy9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvanNvbnJwYy9KU09OUlBDQ2xpZW50Lmt0) | `51.92% <0.00%> (+1.92%)` | `4.00% <0.00%> (ø%)` | |
| [...apache/tuweni/concurrent/coroutines/AsyncResult.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNSZXN1bHQua3Q=) | `82.97% <0.00%> (+2.12%)` | `0.00% <0.00%> (ø%)` | |
| [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/207/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `82.90% <0.00%> (+3.41%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=footer). Last update [4e68c5a...abc6439](https://codecov.io/gh/apache/incubator-tuweni/pull/207?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] melowe commented on pull request #207: Add Auto-Module-Name attribute to manifest.mf
Posted by GitBox <gi...@apache.org>.
melowe commented on pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#issuecomment-815684294
Need to removed hyphens from module names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org