[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2518: [Bug][Core] fix ArrayType convert for spark2.4.0 and improve the convert method name

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2518:
URL: https://github.com/apache/incubator-seatunnel/pull/2518#discussion_r954749014


##########
seatunnel-translation/seatunnel-translation-base/src/main/java/org/apache/seatunnel/translation/serialization/RowConverter.java:
##########
@@ -124,5 +124,5 @@ protected boolean validate(Object field, SeaTunnelDataType<?> dataType) {
      *
      * @throws IOException Thrown, if the conversion fails.
      */
-    public abstract SeaTunnelRow convert(T engineRow) throws IOException;
+    public abstract SeaTunnelRow reconvert(T engineRow) throws IOException;

Review Comment:
   > Why need to be renamed?
   
   The same problem as @hailin0 .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org