You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@labs.apache.org by si...@apache.org on 2008/10/01 09:39:23 UTC
svn commit: r700703 - in /labs/magma/trunk/foundation-basics/src:
main/java/org/apache/magma/basics/utils/
test/java/org/apache/magma/basics/utils/
test/java/org/apache/magma/basics/utils/genericstuff/
Author: simoneg
Date: Wed Oct 1 00:39:23 2008
New Revision: 700703
URL: http://svn.apache.org/viewvc?rev=700703&view=rev
Log:
Bug and fix to find multiple methods correctly
Modified:
labs/magma/trunk/foundation-basics/src/main/java/org/apache/magma/basics/utils/GenericClass.java
labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/TestGenericClass.java
labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/genericstuff/ConcreteThing.java
Modified: labs/magma/trunk/foundation-basics/src/main/java/org/apache/magma/basics/utils/GenericClass.java
URL: http://svn.apache.org/viewvc/labs/magma/trunk/foundation-basics/src/main/java/org/apache/magma/basics/utils/GenericClass.java?rev=700703&r1=700702&r2=700703&view=diff
==============================================================================
--- labs/magma/trunk/foundation-basics/src/main/java/org/apache/magma/basics/utils/GenericClass.java (original)
+++ labs/magma/trunk/foundation-basics/src/main/java/org/apache/magma/basics/utils/GenericClass.java Wed Oct 1 00:39:23 2008
@@ -306,7 +306,7 @@
MethodDef oth = (MethodDef) other;
return
(method.getName().equals(oth.method.getName())) &&
- (Arrays.equals(params, oth.params));
+ (Arrays.equals(getParameterTypes(), oth.getParameterTypes()));
}
public Class<?> getDeclaringClass() {
Modified: labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/TestGenericClass.java
URL: http://svn.apache.org/viewvc/labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/TestGenericClass.java?rev=700703&r1=700702&r2=700703&view=diff
==============================================================================
--- labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/TestGenericClass.java (original)
+++ labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/TestGenericClass.java Wed Oct 1 00:39:23 2008
@@ -59,6 +59,9 @@
Class<?>[] types = GenericClass.toRawClasses(gr.getParameterTypes(m));
assertThat(types.length, equalTo(1));
assertThat(types[0].getName(), equalTo(Integer.class.getName()));
+
+ methods = gr.findAllMethods("manyOfMe");
+ assertThat(methods.size(), equalTo(2));
}
@Test
Modified: labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/genericstuff/ConcreteThing.java
URL: http://svn.apache.org/viewvc/labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/genericstuff/ConcreteThing.java?rev=700703&r1=700702&r2=700703&view=diff
==============================================================================
--- labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/genericstuff/ConcreteThing.java (original)
+++ labs/magma/trunk/foundation-basics/src/test/java/org/apache/magma/basics/utils/genericstuff/ConcreteThing.java Wed Oct 1 00:39:23 2008
@@ -23,4 +23,7 @@
super.overridable(i);
}
+ public void manyOfMe(String str) {}
+
+ public void manyOfMe(Integer i) {}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@labs.apache.org
For additional commands, e-mail: commits-help@labs.apache.org