You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/06/20 15:25:06 UTC
Review Request 60245: LENS-1443: Fallback ranges not working for
virtual facts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60245/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1443
https://issues.apache.org/jira/browse/LENS-1443
Repository: lens
Description
-------
fallback should also take source fact name, but it's operating with fact name.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java f87cf4434dc53447cb5c8e5d6fc9e252c6f7bc05
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java d9915f4669e728aa061b1cd1a6ee4bb4b7156364
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 22b1d032c0242061fd40cc68f55d962036f6d0b1
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 6e5aa4c292b16f2adef9bcd9c4010053cb8e81d2
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java d7da8cbbcfd0f0cbe145187b7bb184bd0f8b9f4f
Diff: https://reviews.apache.org/r/60245/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60245: LENS-1443: Fallback ranges not working for
virtual facts
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60245/#review178458
-----------------------------------------------------------
Ship it!
Ship It!
- Rajitha R
On June 21, 2017, 6:45 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60245/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 6:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1443
> https://issues.apache.org/jira/browse/LENS-1443
>
>
> Repository: lens
>
>
> Description
> -------
>
> fallback should also take source fact name, but it's operating with fact name.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java f87cf4434dc53447cb5c8e5d6fc9e252c6f7bc05
> lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java d9915f4669e728aa061b1cd1a6ee4bb4b7156364
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 22b1d032c0242061fd40cc68f55d962036f6d0b1
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 6e5aa4c292b16f2adef9bcd9c4010053cb8e81d2
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java d7da8cbbcfd0f0cbe145187b7bb184bd0f8b9f4f
>
>
> Diff: https://reviews.apache.org/r/60245/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 60245: LENS-1443: Fallback ranges not working for
virtual facts
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60245/
-----------------------------------------------------------
(Updated June 21, 2017, 12:15 p.m.)
Review request for lens.
Bugs: LENS-1443
https://issues.apache.org/jira/browse/LENS-1443
Repository: lens
Description
-------
fallback should also take source fact name, but it's operating with fact name.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java f87cf4434dc53447cb5c8e5d6fc9e252c6f7bc05
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java d9915f4669e728aa061b1cd1a6ee4bb4b7156364
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 22b1d032c0242061fd40cc68f55d962036f6d0b1
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 6e5aa4c292b16f2adef9bcd9c4010053cb8e81d2
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java d7da8cbbcfd0f0cbe145187b7bb184bd0f8b9f4f
Diff: https://reviews.apache.org/r/60245/diff/3/
Changes: https://reviews.apache.org/r/60245/diff/2-3/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60245: LENS-1443: Fallback ranges not working for
virtual facts
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60245/
-----------------------------------------------------------
(Updated June 20, 2017, 9 p.m.)
Review request for lens.
Bugs: LENS-1443
https://issues.apache.org/jira/browse/LENS-1443
Repository: lens
Description
-------
fallback should also take source fact name, but it's operating with fact name.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java f87cf4434dc53447cb5c8e5d6fc9e252c6f7bc05
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java d9915f4669e728aa061b1cd1a6ee4bb4b7156364
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 22b1d032c0242061fd40cc68f55d962036f6d0b1
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 6e5aa4c292b16f2adef9bcd9c4010053cb8e81d2
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java d7da8cbbcfd0f0cbe145187b7bb184bd0f8b9f4f
Diff: https://reviews.apache.org/r/60245/diff/2/
Changes: https://reviews.apache.org/r/60245/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal