[GitHub] [felix-dev] cziegeler commented on a diff in pull request #168: FELIX-6551 | OSGi event blocklisting is not informative

[GitBox <gi...@apache.org>]

cziegeler commented on code in PR #168:
URL: https://github.com/apache/felix-dev/pull/168#discussion_r925190383


##########
eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/handler/EventHandlerProxy.java:
##########
@@ -451,7 +451,7 @@ public void denyEventHandler()
     	{
 	        LogWrapper.getLogger().log(
 	                        LogWrapper.LOG_WARNING,
-	                        "Denying event handler from ServiceReference [" + this.reference + " | Bundle("
+	                        "Denying event handler from ServiceReference [" + this.handler.getClass().getCanonicalName() + " | Bundle("

Review Comment:
   I think we should still log the reference and log the classname in addition. Please note that there is a low chance that handler is already null (concurrent requests), so we need to guard against it.
   We should also switch the log level from warning to error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org