You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Daniel Quinlan <qu...@pathname.com> on 2004/02/23 06:47:35 UTC

Re: svn commit: rev 6829 - incubator/spamassassin/trunk/lib/Mail

duncf@apache.org writes:

> -      $hdrs =~ s/^(${header}: .*?)\t\([^)]\)$/$1/gm;
> +      $hdrs =~ s/^(${header}: .*?)\t\([^)]*\)$/$1/gm;

A thought: maybe add some comments for this code, especially this line.

Also, why not [\t ] instead of \t?

Daniel

-- 
Daniel Quinlan                     anti-spam (SpamAssassin), Linux,
http://www.pathname.com/~quinlan/    and open source consulting

Re: svn commit: rev 6829 - incubator/spamassassin/trunk/lib/Mail

Posted by Duncan Findlay <du...@debian.org>.
On Sun, Feb 22, 2004 at 09:47:35PM -0800, Daniel Quinlan wrote:
> duncf@apache.org writes:
> 
> > -      $hdrs =~ s/^(${header}: .*?)\t\([^)]\)$/$1/gm;
> > +      $hdrs =~ s/^(${header}: .*?)\t\([^)]*\)$/$1/gm;
> 
> A thought: maybe add some comments for this code, especially this line.
> 
> Also, why not [\t ] instead of \t?

AFAICR, the code that adds the tag uses a \t. 

-- 
Duncan Findlay