You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2011/06/24 22:25:47 UTC

[jira] [Updated] (PIG-2139) LogicalExpressionSimplifier optimizer rule should check if udf is deterministic while checking if they are equal

     [ https://issues.apache.org/jira/browse/PIG-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thejas M Nair updated PIG-2139:
-------------------------------

    Attachment: PIG-2139.1.patch

unit tests and test-patch passed with PIG-2139.1.patch. It also fixes a NPE issue seen in LogicalExpressionSimplifier when optimization runs on udfs with no arguments.

> LogicalExpressionSimplifier optimizer rule should check if udf is deterministic while checking if they are equal
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2139
>                 URL: https://issues.apache.org/jira/browse/PIG-2139
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.10
>
>         Attachments: PIG-2139.1.patch
>
>
> LogicalExpressionSimplifier simplifies filter expressions. In the process, it compares udfs to see if they are 'equal' (ie expected to produce same results). But it does not check if the udfs are annotated as @Nondeterministic. If such an annotation exists, then the udfs should not be considered equal. UserFuncition.isEqual() is being used to compare the udfs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira