You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2014/05/23 19:21:01 UTC

[jira] [Commented] (OOZIE-1804) Improve documentation for Coordinator Specification

    [ https://issues.apache.org/jira/browse/OOZIE-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007409#comment-14007409 ] 

Robert Kanter commented on OOZIE-1804:
--------------------------------------

Thanks for noticing and fixing the description of the done-flag and other typos.  

The patch didn't apply because you need to specify {{--no-prefix}} when doing {{git diff}} to make it not generate paths with "a" and "b" prefixes.  i.e. {{git diff --no-prefix}}

Can you reupload the patch with the {{--no-prefix}} option?  While you're at it, can you also add newlines to the lines that you changed to make them less than 132 characters?  There's no need to do that to the entire file, just do it for the lines that you've changed; however, keep in mind that certain twiki formatting won't work if lines are split like that (e.g. bullet points) so in those cases, you can leave them being long.  
Don't forget to rebase to the latest master too.

> Improve documentation for Coordinator Specification
> ---------------------------------------------------
>
>                 Key: OOZIE-1804
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1804
>             Project: Oozie
>          Issue Type: Improvement
>          Components: docs
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Trivial
>         Attachments: OOZIE-1804.1.patch
>
>
> The description of the done-flag is confusing and partially wrong.
> In addition I've fixed a couple of small typos and removed extra whitespace.



--
This message was sent by Atlassian JIRA
(v6.2#6252)