[GitHub] [ozone] jojochuang commented on a diff in pull request #3768: HDDS-7208. Erasure coding and encryption are not flagged on FileStatus

[GitBox <gi...@apache.org>]

jojochuang commented on code in PR #3768:
URL: https://github.com/apache/ozone/pull/3768#discussion_r976982379


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java:
##########
@@ -534,7 +536,10 @@ private FileStatusAdapter toFileStatusAdapter(OzoneFileStatus status,
         owner,
         owner,
         null,
-        getBlockLocations(status)
+        getBlockLocations(status),
+        !Objects.isNull(keyInfo.getFileEncryptionInfo()),
+        keyInfo.getReplicationConfig().getReplicationType() ==
+        HddsProtos.ReplicationType.EC

Review Comment:
   how about creating a helper method isErasureCoded() in OzoneClientAdpter and move this code there so that this code can be shared by both BasicOzoneClientAdapterImpl and BasicOzoneRootedOzoneClientAdapterImpl?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org