You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/12 20:10:55 UTC
[GitHub] [beam] jrmccluskey opened a new pull request, #22249: Move Xlang Go examples to generic registration
jrmccluskey opened a new pull request, #22249:
URL: https://github.com/apache/beam/pull/22249
Shift to using the new generic registration for DoFns, combiners, iterators, and emitters in the cross-language Go example pipelines.
Part of #22243
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #22249: Move Xlang Go examples to generic registration
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22249:
URL: https://github.com/apache/beam/pull/22249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #22249: Move Xlang Go examples to generic registration
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #22249:
URL: https://github.com/apache/beam/pull/22249#discussion_r919432177
##########
sdks/go/examples/xlang/cogroup_by/cogroup_by.go:
##########
@@ -76,6 +77,13 @@ func init() {
beam.RegisterFunction(formatFn)
beam.RegisterFunction(getKV)
beam.RegisterFunction(sumCounts)
+
Review Comment:
We can cut the above calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22249: Move Xlang Go examples to generic registration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22249:
URL: https://github.com/apache/beam/pull/22249#issuecomment-1182478649
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #22249: Move Xlang Go examples to generic registration
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on code in PR #22249:
URL: https://github.com/apache/beam/pull/22249#discussion_r919436701
##########
sdks/go/examples/xlang/cogroup_by/cogroup_by.go:
##########
@@ -76,6 +77,13 @@ func init() {
beam.RegisterFunction(formatFn)
beam.RegisterFunction(getKV)
beam.RegisterFunction(sumCounts)
+
Review Comment:
Whoops, forgot to get them all out. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org